OCPBUGS-99492: remove storage NetworkPolicies from validation skip list

[dobsonj]

https://redhat.atlassian.net/browse/OCPBUGS-99492

/hold for openshift/cluster-storage-operator#720

/cc @openshift/storage

Summary by CodeRabbit

• Tests
  • Updated NetworkPolicy validation coverage to include additional platform policies.
  • Named-port violations in these policies are now detected instead of being skipped.

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/hold for openshift/cluster-storage-operator#720

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/hold for openshift/cluster-storage-operator#720

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 00e2bbc7-ed7f-4691-97d2-6d9555da175a

📥 Commits

Reviewing files that changed from the base of the PR and between 398edca and 791636e.

📒 Files selected for processing (1)

• test/extended/networking/networkpolicy_validation.go

💤 Files with no reviewable changes (1)

• test/extended/networking/networkpolicy_validation.go

---

Walkthrough

The NetworkPolicy validation test removes two platform DNS policies from its skip list, causing them to be checked for named-port violations alongside the other retained policies.

Changes

NetworkPolicy validation

Layer / File(s)	Summary
Update validation skip list test/extended/networking/networkpolicy_validation.go	Removes the CSI driver and storage operator allow-to-dns policies from networkPoliciesToSkip.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• openshift/origin#31375: Updates the same NetworkPolicy validation test’s platform-policy skip-list handling.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing storage NetworkPolicies from the validation skip list.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only Ginkgo title in the changed file is static; this PR only trims a skip list and adds no dynamic test names.
Test Structure And Quality	✅ Passed	The PR only removes two entries from an existing skip list; it doesn't add new test logic or introduce setup, timeout, or assertion issues.
Microshift Test Compatibility	✅ Passed	PASS: The PR only trims a skip list in an existing [apigroup:networking.k8s.io] NetworkPolicy test; it adds no new MicroShift-unsafe APIs or features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo tests were added; the existing validation only scans NetworkPolicies and has no multi-node or HA assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a validation test changed; no deployment, controller, or scheduling code/manifests were introduced.
Ote Binary Stdout Contract	✅ Passed	Changed file only edits a Ginkgo It body; no main/TestMain/BeforeSuite code or stdout writes were added, and e2e.Logf is test-block output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo test was added; this PR only removes two NetworkPolicy skips and the existing validation test has no IPv4-only or external connectivity assumptions.
No-Weak-Crypto	✅ Passed	The PR only removes two NetworkPolicy test exemptions; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons are added.
Container-Privileges	✅ Passed	PR only edits a Go test skip list; no container/K8s manifest privilege settings were added or changed.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only removes two skip-list entries; it adds no new logging and does not expose passwords, tokens, PII, or other sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dobsonj
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/extended/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99492

/hold for openshift/cluster-storage-operator#720

/cc @openshift/storage

Summary by CodeRabbit

• Tests
• Updated NetworkPolicy validation coverage to include additional platform policies.
• Named-port violations in these policies are now detected instead of being skipped.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dobsonj]

/jira refresh

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-99492, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-deps	791636e	link	true	/test verify-deps
ci/prow/go-verify-deps	791636e	link	true	/test go-verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.