OCPBUGS-99533: Add Additional Storage Support - API validation test cases by BhargaviGudi · Pull Request #31418 · openshift/origin

BhargaviGudi · 2026-07-23T06:41:37Z

Manual cherry-pick of PR #31384
Summary:
Add comprehensive API validation tests for Additional Storage Support (additionalArtifactStores, additionalImageStores, additionalLayerStores) feature. These tests validate ContainerRuntimeConfig API behavior
using DryRun, ensuring proper validation without triggering MCO reconciliation.

test/extended/node/additional_storage_api.go - 13 API validation tests

openshift-merge-bot · 2026-07-23T06:41:39Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-07-23T06:41:40Z

@BhargaviGudi: This pull request explicitly references no jira issue.

Details

In response to this:

Manual cherry-pick of PR #31384
Summary:
Add comprehensive API validation tests for Additional Storage Support (additionalArtifactStores, additionalImageStores, additionalLayerStores) feature. These tests validate ContainerRuntimeConfig API behavior
using DryRun, ensuring proper validation without triggering MCO reconciliation.

test/extended/node/additional_storage_api.go - 13 API validation tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-23T06:41:45Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b6842e2a-6b1d-4799-8aab-f84c4e3c1b36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-07-23T06:42:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BhargaviGudi
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

test/extended/node/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BhargaviGudi · 2026-07-23T06:42:31Z

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview

openshift-ci · 2026-07-23T06:42:34Z

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aea00b70-8661-11f1-95c9-0c879d5f79a3-0

BhargaviGudi · 2026-07-23T06:43:04Z

/assign @saschagrunert @ngopalak-redhat

saschagrunert

One blocking issue: error-swallowing in the skip helper. Non-blocking nits shared in the terminal.

saschagrunert · 2026-07-23T07:08:21Z

+	if err != nil {
+		framework.Logf("Failed to detect MicroShift cluster: %v", err)
+		g.Skip("Cannot verify cluster type")
+	}


This swallows API errors by skipping. If IsMicroShiftCluster fails for an unexpected reason (e.g., kube API unreachable, auth issue), the test silently never runs and nobody notices.

The established pattern in this directory (see kubelet_secret_pulled_images.go line 56) is:

o.Expect(err).NotTo(o.HaveOccurred())

Same issue applies to the Infrastructures().Get() error handling below on line 758. Both should fail the test on unexpected errors rather than skip.

Updated.
I have removed microft azure skip for now to check whether the feature works on azure. Is that skip required? I believe feature should work on azure platform.

This check moved https://github.com/openshift/origin/pull/31418/changes#diff-6cdaa2d702b7181438fcc46676220b9ae55135b9481bf8531a28f34c745c2a4aR23 as per the content from main branch.

openshift-merge-bot · 2026-07-23T07:09:17Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

BhargaviGudi · 2026-07-23T07:56:16Z

/label backport-risk-assessed

openshift-ci · 2026-07-23T07:56:45Z

@BhargaviGudi: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-07-23T08:18:39Z

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-99533, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-99533 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of PR #31384
Summary:
Add comprehensive API validation tests for Additional Storage Support (additionalArtifactStores, additionalImageStores, additionalLayerStores) feature. These tests validate ContainerRuntimeConfig API behavior
using DryRun, ensuring proper validation without triggering MCO reconciliation.

test/extended/node/additional_storage_api.go - 13 API validation tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

BhargaviGudi · 2026-07-23T08:28:35Z

/jira refresh

openshift-ci-robot · 2026-07-23T08:28:41Z

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-99533, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-99532 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-99532 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

BhargaviGudi · 2026-07-23T08:52:05Z

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview

openshift-ci · 2026-07-23T08:55:26Z

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c82e6200-8673-11f1-9176-a0ccc3be4485-0

BhargaviGudi · 2026-07-23T09:20:37Z

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview

openshift-ci · 2026-07-23T09:22:23Z

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c46ec520-8677-11f1-8288-20bd097f8bbd-0

openshift-merge-bot · 2026-07-23T09:46:47Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

BhargaviGudi · 2026-07-23T10:25:12Z

/verified by CI periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview

openshift-ci-robot · 2026-07-23T10:25:25Z

@BhargaviGudi: This PR has been marked as verified by CI [periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview](https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-31418-ci-4.22-e2e-gcp-ovn-techpreview/2080181763132362752).

Details

In response to this:

/verified by CI periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

BhargaviGudi · 2026-07-23T12:18:33Z

Test cases passed on azure-ovn

BhargaviGudi · 2026-07-23T14:24:57Z

ci/prow/e2e-gcp-ovn failure is not related to this PR

BhargaviGudi · 2026-07-23T14:38:49Z

/test e2e-gcp-ovn

openshift-ci · 2026-07-23T18:05:27Z

@BhargaviGudi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2026

openshift-ci Bot requested review from mrunalp and sohankunkerkar July 23, 2026 06:42

openshift-ci Bot assigned ngopalak-redhat and saschagrunert Jul 23, 2026

saschagrunert suggested changes Jul 23, 2026

View reviewed changes

BhargaviGudi changed the title ~~NO-ISSUE: Add Additional Storage Support - API validation test cases~~ OCPBUGS-99533: Add Additional Storage Support - API validation test cases Jul 23, 2026

openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 23, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 23, 2026

BhargaviGudi force-pushed the api-cases-422 branch from 98ad1d4 to 8b23fa2 Compare July 23, 2026 08:51

BhargaviGudi force-pushed the api-cases-422 branch from c189454 to 98ad1d4 Compare July 23, 2026 08:58

Manual cherry-pick of PR openshift#31384

0509fc6

BhargaviGudi force-pushed the api-cases-422 branch from 8b23fa2 to 0509fc6 Compare July 23, 2026 09:18

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 23, 2026

Uh oh!

Conversation

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

openshift-ci-robot commented Jul 23, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

saschagrunert Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

BhargaviGudi Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

BhargaviGudi Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

openshift-ci-robot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-ci-robot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-ci-robot commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

BhargaviGudi commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading