OCPBUGS-84255: Fix project name error during wait

[xueqzhan]

Summary by CodeRabbit

• Tests
  • Fixed watch event filtering logic to correctly identify project names instead of incorrectly comparing type-cast results, ensuring stray events are properly excluded based on actual project identity.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@xueqzhan: This pull request references Jira Issue OCPBUGS-84255, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a812d4ba-b766-4817-94f5-c3c92d293388

📥 Commits

Reviewing files that changed from the base of the PR and between 0d2dab5 and c5d9d91.

📒 Files selected for processing (1)

• test/extended/project/project.go

---

Walkthrough

A bug fix in the waitForNoEvent function corrects an assertion that was comparing a type-cast success flag instead of the actual project name. The logic now properly validates the watched object's name against the expected skip value.

Changes

Cohort / File(s)	Summary
Test assertion fix test/extended/project/project.go	Corrected assertion in waitForNoEvent to compare project.Name against skipProject instead of incorrectly comparing the type-cast success flag ok.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'OCPBUGS-84255: Fix project name error during wait' clearly and specifically describes the main change: fixing a project name error that occurs during a wait operation.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request modifies only assertion logic within the waitForNoEvent helper function, without altering test name declarations. All test names remain static and deterministic.
Test Structure And Quality	✅ Passed	PR fixes logic error in waitForNoEvent helper function where assertion incorrectly compared type-cast flag to project name instead of actual project name. Corrected code properly asserts project.Name equals skipProject with proper timeout handling and consistent Ginkgo patterns.
Microshift Test Compatibility	✅ Passed	The PR only modifies an existing helper function in the project test file, fixing a logic error. No new Ginkgo test definitions are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only fixes a bug in the existing waitForNoEvent helper function by correcting an assertion to compare project.Name against skipProject instead of comparing a boolean type-cast result. No new Ginkgo e2e tests are added.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request modifies only a test utility function fixing an assertion bug, introducing no scheduling constraints or topology assumptions.
Ote Binary Stdout Contract	✅ Passed	Pull request modifies a test helper function in a Ginkgo test suite file with only test code and no process-level code, introducing no stdout violations.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This pull request does not add new Ginkgo e2e tests; it only fixes a logic error in an existing test helper function, making the IPv6 and disconnected network compatibility check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[xueqzhan]

/payload-job periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance

[openshift-ci]

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/85004630-3f4f-11f1-9823-8d4f6b084dc6-0

[xueqzhan]

/payload-job periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance

[openshift-ci]

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f2bac50-3f50-11f1-87fd-4874b9f76abb-0

[xueqzhan]

/retest-required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[xueqzhan]

/test e2e-aws-csi

[dgoodwin]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coderabbitai[bot], dgoodwin, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dgoodwin,xueqzhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xueqzhan]

/verified by @xueqzhan

[openshift-ci-robot]

@xueqzhan: This PR has been marked as verified by @xueqzhan.

Details

In response to this:

/verified by @xueqzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xueqzhan]

/verified by @xueqzhan

[openshift-ci-robot]

@xueqzhan: This PR has been marked as verified by @xueqzhan.

Details

In response to this:

/verified by @xueqzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xueqzhan]

/label verified

[xueqzhan]

/jira refresh

[openshift-ci-robot]

@xueqzhan: This pull request references Jira Issue OCPBUGS-84255, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@xueqzhan: Jira Issue Verification Checks: Jira Issue OCPBUGS-84255
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84255 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary by CodeRabbit

• Tests
• Fixed watch event filtering logic to correctly identify project names instead of incorrectly comparing type-cast results, ensuring stray events are properly excluded based on actual project identity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xueqzhan]

/cherrypick release-4.22

[openshift-cherrypick-robot]

@xueqzhan: new pull request created: #31085

Details

In response to this:

/cherrypick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-robot]

Fix included in release 5.0.0-0.nightly-2026-04-28-195058