Skip to content

OCPBUGS-83801:skip serial and disruptive cases from suite#31042

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
gangwgr:fix-ci-ir
Apr 22, 2026
Merged

OCPBUGS-83801:skip serial and disruptive cases from suite#31042
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
gangwgr:fix-ci-ir

Conversation

@gangwgr
Copy link
Copy Markdown
Contributor

@gangwgr gangwgr commented Apr 20, 2026

skip serial and disruptive cases from suite which causing monitor cases failure
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-image-registry-operator/1322/pull-ci-openshift-cluster-image-registry-operator-release-4.22-e2e-aws-ovn-image-registry/2046176460850335744

Summary by CodeRabbit

  • Chores
    • Refined standard test-suite filtering to additionally exclude tests marked disruptive and serial from standard runs, alongside existing exclusions. This prevents certain slow or stateful tests from running in routine executions, improving overall test stability and reducing time to feedback for typical test runs.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Walkthrough

Updated the openshift/image-registry test suite qualifier to exclude tests tagged [Local], [Disruptive], and [Serial] in addition to retaining the [sig-imageregistry] inclusion.

Changes

Cohort / File(s) Summary
Test Suite Filter
pkg/testsuites/standard_suites.go
Adjusted the Qualifiers expression for the openshift/image-registry suite from [sig-imageregistry] && ![Local] to [sig-imageregistry] && ![Local] && ![Disruptive] && ![Serial].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The custom check for stable test names is not applicable to this PR as it modifies a test suite configuration file using static, deterministic filter expressions with no dynamic elements.
Test Structure And Quality ✅ Passed PR modifies test suite configuration filtering, not Ginkgo test implementations, so custom check for test code quality does not apply.
Microshift Test Compatibility ✅ Passed PR modifies only test filtering qualifiers for existing test suite, not adding new Ginkgo e2e tests, so MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only modifies a qualifier expression in test suite configuration to filter existing tests.
Topology-Aware Scheduling Compatibility ✅ Passed Change modifies only test suite filtering logic in pkg/testsuites/standard_suites.go (line 194), adding exclusions for tests tagged with [Disruptive] and [Serial]. This is purely test orchestration configuration with no impact on deployment manifests, operator code, or Kubernetes scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The change modifies a CEL expression filter string using fmt.Sprintf(), which returns a string without writing to stdout. No stdout operations are introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request modifies test suite filtering to exclude [Disruptive] and [Serial] tests, not adding new Ginkgo e2e tests with potential IPv4/disconnected network compatibility issues.
Title check ✅ Passed The title directly and clearly describes the main change: excluding serial and disruptive test cases from the suite, which matches the file modification shown in the raw summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pkg/testsuites/standard_suites.go`:
- Line 194: The filter string passed to withStandardEarlyOrLateTests is missing
a closing parenthesis for the !name.contains('[Local]' sub-expression; update
the argument to close that parenthesis so the expression becomes
"name.contains('[sig-imageregistry]') && !name.contains('[Local]') &&
!name.contains('[Disruptive]') && !name.contains('[Serial]')" (ensure the
corrected string is used as the parameter to withStandardEarlyOrLateTests and
that all parentheses and quotes are balanced).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fde867a1-f76a-483b-90bb-42604f348a39

📥 Commits

Reviewing files that changed from the base of the PR and between ff48d7a and 5677ed5.

📒 Files selected for processing (1)
  • pkg/testsuites/standard_suites.go

Comment thread pkg/testsuites/standard_suites.go Outdated
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 20, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 20, 2026

/pipeline required

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 20, 2026

/retest-required

1 similar comment
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 20, 2026

/retest-required

@gangwgr gangwgr changed the title skip serial and disruptive cases from suite OCPBUGS-83801:skip serial and disruptive cases from suite Apr 20, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gangwgr: This pull request references Jira Issue OCPBUGS-83801, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

skip serial and disruptive cases from suite which causing monitor cases failure
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-image-registry-operator/1322/pull-ci-openshift-cluster-image-registry-operator-release-4.22-e2e-aws-ovn-image-registry/2046176460850335744

Summary by CodeRabbit

  • Chores
  • Refined standard test-suite filtering to additionally exclude tests marked disruptive and serial from standard runs, alongside existing exclusions. This prevents certain slow or stateful tests from running in routine executions, improving overall test stability and reducing time to feedback for typical test runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125
Copy link
Copy Markdown
Contributor

dusk125 commented Apr 20, 2026

/lgtm
But let's get @flavianmissi to review as well. Do you foresee any issues with disabling these?

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 20, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gangwgr: This pull request references Jira Issue OCPBUGS-83801, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: gangwgr.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@gangwgr: This pull request references Jira Issue OCPBUGS-83801, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 20, 2026

/retest-required

3 similar comments
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

3 similar comments
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

@jmguzik
Copy link
Copy Markdown

jmguzik commented Apr 21, 2026

/pipeline required

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@jmguzik
Copy link
Copy Markdown

jmguzik commented Apr 21, 2026

/pipeline required

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-trt
Copy link
Copy Markdown

openshift-trt Bot commented Apr 21, 2026

Job Failure Risk Analysis for sha: 5cbb3d4

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (21) are below the historical average (1914): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (22) are below the historical average (3305): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (18) are below the historical average (1778): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (18) are below the historical average (916): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (21) are below the historical average (2067): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (21) are below the historical average (1973): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (20) are below the historical average (1860): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn IncompleteTests
Tests for this run (20) are below the historical average (3517): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (16) are below the historical average (3255): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn IncompleteTests
Tests for this run (18) are below the historical average (3148): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (18) are below the historical average (3278): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 21, 2026

/verified by @gangwgr

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gangwgr: This PR has been marked as verified by @gangwgr.

Details

In response to this:

/verified by @gangwgr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, gangwgr, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-merge-bot openshift-merge-bot Bot merged commit cad1b7a into openshift:main Apr 22, 2026
21 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@gangwgr: Jira Issue Verification Checks: Jira Issue OCPBUGS-83801
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-83801 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

skip serial and disruptive cases from suite which causing monitor cases failure
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-image-registry-operator/1322/pull-ci-openshift-cluster-image-registry-operator-release-4.22-e2e-aws-ovn-image-registry/2046176460850335744

Summary by CodeRabbit

  • Chores
  • Refined standard test-suite filtering to additionally exclude tests marked disruptive and serial from standard runs, alongside existing exclusions. This prevents certain slow or stateful tests from running in routine executions, improving overall test stability and reducing time to feedback for typical test runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

@gangwgr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 23, 2026

/cherry-pick release-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gangwgr: new pull request created: #31057

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants