Skip to content

OSDOCS-18179-bug-batch-oc-4-22 RNs#112589

Merged
JoeAldinger merged 1 commit into
openshift:enterprise-4.22from
wgabor0427:OSODCS-18179-bug-batch-oc-4-22
Jun 2, 2026
Merged

OSDOCS-18179-bug-batch-oc-4-22 RNs#112589
JoeAldinger merged 1 commit into
openshift:enterprise-4.22from
wgabor0427:OSODCS-18179-bug-batch-oc-4-22

Conversation

@wgabor0427
Copy link
Copy Markdown
Contributor

@wgabor0427 wgabor0427 commented Jun 1, 2026

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2026
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Jun 1, 2026

🤖 Mon Jun 01 20:40:25 - Prow CI generated the docs preview:

https://112589--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-22-release-notes.html

@wgabor0427 wgabor0427 force-pushed the OSODCS-18179-bug-batch-oc-4-22 branch from 787343e to f31bdf8 Compare June 1, 2026 20:07
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2026
@wgabor0427 wgabor0427 force-pushed the OSODCS-18179-bug-batch-oc-4-22 branch from f31bdf8 to df0b7ba Compare June 1, 2026 20:18
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2026
@wgabor0427 wgabor0427 force-pushed the OSODCS-18179-bug-batch-oc-4-22 branch from df0b7ba to c295391 Compare June 1, 2026 20:31
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wgabor0427
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 2, 2026
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 2, 2026

* Before this update, the `oc adm node-image create` command attempted to contact `quay.io` first instead of using the mirror registry when generating a discovery ISO for node addition in disconnected environments. As a consequence, in environments with strict firewall restrictions, the `node-joiner` process hung waiting for a connection to `quay.io`, even though all necessary images existed in the `ImageContentSourcePolicy` (ICSP) or `ImageDigestMirrorSet` (IDMS) configuration. With this release, the `oc` client directly references mirrors defined in ICSP or IDMS before attempting to contact external registries. As a result, discovery ISO creation succeeds in disconnected environments where a proxy responds on behalf of `quay.io`, but `quay.io` itself cannot be reached. (link:https://redhat.atlassian.net/browse/OCPBUGS-64840[OCPBUGS-64840])

* Before this update, when using the `oc expose service` command with the `--labels` option to create a Route, the command ignored the custom labels. As a consequence, the resulting route resource used the service selector as its labels instead of the labels specified in the `--labels` option. With this release, the `oc expose service` command correctly applies custom labels from the `--labels` option to the route resource. (link:https://redhat.atlassian.net/browse/OCPBUGS-74543[OCPBUGS-74543])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Before this update, when using the `oc expose service` command with the `--labels` option to create a Route, the command ignored the custom labels. As a consequence, the resulting route resource used the service selector as its labels instead of the labels specified in the `--labels` option. With this release, the `oc expose service` command correctly applies custom labels from the `--labels` option to the route resource. (link:https://redhat.atlassian.net/browse/OCPBUGS-74543[OCPBUGS-74543])
* Before this update, when using the `oc expose service` command with the `--labels` option to create a route, the command ignored the custom labels. As a consequence, the resulting route resource used the service selector as its labels instead of the labels specified in the `--labels` option. With this release, the `oc expose service` command correctly applies custom labels from the `--labels` option to the route resource. (link:https://redhat.atlassian.net/browse/OCPBUGS-74543[OCPBUGS-74543])

Copy link
Copy Markdown
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm small typo maybe you could fix in another bug batch PR. Up to you though.

@JoeAldinger JoeAldinger merged commit a477a18 into openshift:enterprise-4.22 Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-review-in-progress Signifies that the merge review team is reviewing this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants