Skip to content

OSDOCS Fix numbering issues in Configuring credentials that allow images to be mirrored#112576

Merged
bscott-rh merged 1 commit into
openshift:mainfrom
mburke5678:fix-errors-configuring-creds
Jun 2, 2026
Merged

OSDOCS Fix numbering issues in Configuring credentials that allow images to be mirrored#112576
bscott-rh merged 1 commit into
openshift:mainfrom
mburke5678:fix-errors-configuring-creds

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented Jun 1, 2026

In fixing another issue, I saw that the numbering in this procedure is incorrect. Apparently, the comments in the steps were breaking the procedure. I see that adding the comments with + character is a fix.

Disconnected environments -> Mirroring images for a disconnected installation by using the oc-mirror plugin v2 -> Configuring credentials that allow images to be mirrored Current docs

Disconnected environments -> Mirroring images for a disconnected installation using the oc-mirror plugin -> Configuring credentials that allow images to be mirrored Current docs

Disconnected environments -> Mirroring images for a disconnected installation by using the oc adm command -> Configuring credentials that allow images to be mirrored Current docs

Disconnected environments -> Updating a cluster in a disconnected environment -> Mirroring OpenShift Container Platform images -> Preparing your mirror host -> Configuring credentials that allow images to be mirrored Current docs

Images -> Using the Cluster Samples Operator with an alternate registry -> Configuring credentials that allow images to be mirrored -- This one looks OK in the Current docs.

There is no OKD preview, but the errors in the file caused formatting issues. Look in the current docs for Mirroring an image set to a mirror registry after this section as an example.
Here is a screenshot of the fix in a local preview:
image

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 added this to the Continuous Release milestone Jun 1, 2026
@mburke5678 mburke5678 added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 1, 2026
@mburke5678 mburke5678 changed the title Fix numbering issues in Configuring credentials that allow images to be mirrored OSDOCS Fix numbering issues in Configuring credentials that allow images to be mirrored Jun 1, 2026
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 2, 2026
Copy link
Copy Markdown
Contributor

@bscott-rh bscott-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM.

@bscott-rh bscott-rh merged commit cf200ef into openshift:main Jun 2, 2026
2 checks passed
@bscott-rh
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bscott-rh: #112576 failed to apply on top of branch "enterprise-4.16":

Applying: Fix numbering issues in Configuring credentials that allow images to be mirrored
.git/rebase-apply/patch:36: trailing whitespace.
	
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/installation-adding-registry-pull-secret.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-adding-registry-pull-secret.adoc
CONFLICT (content): Merge conflict in modules/installation-adding-registry-pull-secret.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix numbering issues in Configuring credentials that allow images to be mirrored

Details

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bscott-rh: new pull request created: #112667

Details

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bscott-rh: new pull request created: #112668

Details

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bscott-rh: new pull request created: #112669

Details

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bscott-rh: new pull request created: #112670

Details

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bscott-rh: new pull request created: #112671

Details

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bscott-rh: new pull request created: #112672

Details

In response to this:

/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
/cherrypick enterprise-4.18
/cherrypick enterprise-4.19
/cherrypick enterprise-4.20
/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants