Skip to content

DOCPLAN-382:FixRemainingValeWarnings#112462

Merged
danielclowers merged 1 commit into
openshift:mainfrom
klgill:fix-oadp-concept-links
Jun 1, 2026
Merged

DOCPLAN-382:FixRemainingValeWarnings#112462
danielclowers merged 1 commit into
openshift:mainfrom
klgill:fix-oadp-concept-links

Conversation

@klgill
Copy link
Copy Markdown
Contributor

@klgill klgill commented May 28, 2026

Used Claude to fix ConceptLink warnings, and I manually fixed a couple other AsciiDocDITA warnings.

Version(s):
4.20, 4.21, 4.22

Issue:
https://redhat.atlassian.net/browse/DOCPLAN-382

Link to docs preview:
https://112462--ocpdocs-pr.netlify.app/

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 28, 2026

@klgill: This pull request references DOCPLAN-382 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.20, 4.21, 4.22

Issue:
https://redhat.atlassian.net/browse/DOCPLAN-382

Link to docs preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2026
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented May 28, 2026

🤖 Mon Jun 01 17:30:00 - Prow CI generated the docs preview:
https://112462--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

Copy link
Copy Markdown
Contributor

@anarnold97 anarnold97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i think it catches nearly everything in the report

@klgill
Copy link
Copy Markdown
Contributor Author

klgill commented Jun 1, 2026

/merge-review-needed

@klgill
Copy link
Copy Markdown
Contributor Author

klgill commented Jun 1, 2026

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 1, 2026
@klgill klgill force-pushed the fix-oadp-concept-links branch from d8a5a1e to 600a9c4 Compare June 1, 2026 16:19

[role="_additional-resources"]
.Additional resources

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This orphaned bullet point should either be removed (if the Velero overview link is already covered in the Additional resources section below) or moved into the Additional resources section for consistency with the rest of the Vale warning fixes in this PR.

DOCPLAN-382:Peer edits

removed stray Valero bullet
@klgill klgill force-pushed the fix-oadp-concept-links branch from 600a9c4 to d9b41ee Compare June 1, 2026 17:20
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 1, 2026

@klgill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielclowers danielclowers added CNV Label for all CNV PRs branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 1, 2026
@danielclowers danielclowers added this to the Continuous Release milestone Jun 1, 2026
@danielclowers
Copy link
Copy Markdown
Contributor

LGTM

@danielclowers danielclowers merged commit 1ace7ef into openshift:main Jun 1, 2026
2 checks passed
@danielclowers
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.20

@danielclowers
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.21

@danielclowers
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@danielclowers: #112462 failed to apply on top of branch "enterprise-4.20":

Applying: DOCPLAN-382:FixRemainingValeWarnings
.git/rebase-apply/patch:95: trailing whitespace.
The Data Mover uses Kopia as the uploader mechanism to read the snapshot data and write to the unified repository. 
.git/rebase-apply/patch:374: trailing whitespace.
* link:https://pkg.go.dev/github.com/openshift/oadp-operator[OADP Operator (Go documentation)] 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.adoc
M	backup_and_restore/application_backup_and_restore/installing/installing-oadp-azure.adoc
M	backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
M	backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
M	backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
Falling back to patching base and 3-way merge...
Auto-merging backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
CONFLICT (content): Merge conflict in backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.adoc
Auto-merging backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
CONFLICT (content): Merge conflict in backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.adoc
Auto-merging backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
CONFLICT (content): Merge conflict in backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.adoc
Auto-merging backup_and_restore/application_backup_and_restore/installing/installing-oadp-azure.adoc
CONFLICT (content): Merge conflict in backup_and_restore/application_backup_and_restore/installing/installing-oadp-azure.adoc
Auto-merging backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 DOCPLAN-382:FixRemainingValeWarnings

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@danielclowers: new pull request created: #112584

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@danielclowers: new pull request created: #112585

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants