USHIFT-6973: Minor refactor of CIS scenarios and RF test#7087
Conversation
|
@ggiguash: This pull request references USHIFT-6973 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
WalkthroughThe CIS periodic scripts now configure repositories during VM creation and pass installation variables to Robot. The CIS suite validates required inputs and installs MicroShift through repo-based RPM helpers, which now support optional extra ChangesCIS installation and periodic setup
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant PeriodicScript
participant VM
participant RobotSuite
participant RPMRepository
PeriodicScript->>VM: configure repositories during VM creation
PeriodicScript->>RobotSuite: pass source URL and target version
RobotSuite->>RobotSuite: validate required variables
RobotSuite->>RPMRepository: install MicroShift RPM with --nogpgcheck
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test ? |
|
/test e2e-aws-tests-bootc-periodic-arm-el10 |
|
/assign @copejon |
|
All tests passed, but infra teardown failed. will try it one more time /test e2e-aws-tests-bootc-el9 |
|
/verified by ci |
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override e2e-aws-tests-bootc-el9 |
|
@copejon: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-aws-tests-bootc-el9 |
|
@copejon: Overrode contexts on behalf of copejon: ci/prow/e2e-aws-tests-bootc-el9 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Follow-up on #7041
Summary by CodeRabbit
New Features
Bug Fixes
Tests