Skip to content

fix(deps): update gomod dependencies#597

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
smarthall:fix/update-gomod-dependencies
Jul 15, 2026
Merged

fix(deps): update gomod dependencies#597
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
smarthall:fix/update-gomod-dependencies

Conversation

@smarthall

@smarthall smarthall commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Updates k8s.io packages from v0.35.x to v0.36.2
  • Updates sigs.k8s.io/controller-runtime from v0.23.3 to v0.24.1
  • Updates go-openapi/swag packages to v0.27.0
  • Updates openshift/api to latest (v0.0.0-20260714141955) to resolve compatibility with k8s.io/api v0.36 (removed beta APIs)
  • Updates openshift/hive/apis to latest
  • Includes go.sum regeneration via go mod tidy

Supersedes #590, which failed CI because:

  1. go.sum was not updated (Renovate artifact pipeline failure)
  2. Merge conflict with master
  3. cluster-logging-operator upgrade removed apis/logging/v1 package (breaking change)
  4. osde2e-common upgrade pulled openshift/api version incompatible with k8s.io/api v0.36

This PR keeps cluster-logging-operator and osde2e-common at their current versions to avoid breaking changes, while applying the compatible dependency upgrades.

Test plan

  • make vet passes
  • make test — all 26 webhook test suites pass
  • make build — binary compiles successfully
  • go mod tidy produces clean state

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Kubernetes, OpenShift, controller-runtime, and related supporting libraries.
    • Refreshed observability, Prometheus, OpenAPI, and Go ecosystem dependencies.
    • Improved compatibility with newer platform components and security updates.

Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
@openshift-ci
openshift-ci Bot requested review from anispate and feichashao July 15, 2026 02:03
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ba84bfa4-1a9a-4d21-941f-498b3021735c

📥 Commits

Reviewing files that changed from the base of the PR and between a9e333c and 367eec0.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Walkthrough

Changes

Dependency refresh

Layer / File(s) Summary
Primary dependency upgrades
go.mod
OpenShift, Kubernetes, utility, and controller-runtime direct dependencies were updated.
Transitive dependency alignment
go.mod
Indirect OpenAPI, telemetry, Prometheus, Go, Kubernetes, and structured-merge dependencies were advanced or removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: dependabot[bot], red-hat-konflux-kflux-prd-rh03[bot]


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❌ Error Branch still has process-level stdout writes: cmd/main.go sends klog to stdout, and cmd/fips.go's init() prints to stdout, violating the JSON-on-stdout contract. Redirect klog to stderr and remove/redirect the init banner in cmd/fips.go; keep diagnostics on stderr or GinkgoWriter.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating Go module dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only go.mod and go.sum changed in HEAD; no test files or Ginkgo titles were modified, so there are no unstable test names to flag.
Test Structure And Quality ✅ Passed PR only changes go.mod/go.sum; no Ginkgo test code was added or modified, so the test-structure checks are not applicable.
Microshift Test Compatibility ✅ Passed This PR only updates go.mod/go.sum; no Go test files or new Ginkgo specs were added, so there’s nothing MicroShift-sensitive to review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only go.mod and go.sum changed; no new or modified Ginkgo tests, so no SNO multi-node assumptions were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod and go.sum changed; no deployment manifests, operators, or controllers were modified, so no topology-aware scheduling risk was introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only go.mod and go.sum changed; no new Ginkgo e2e tests or network-coupled test code were added.
No-Weak-Crypto ✅ Passed Diff only updates go.mod/go.sum and Tekton bundle digests; no weak crypto, custom crypto, or token comparison code was introduced.
Container-Privileges ✅ Passed Only go.mod and go.sum changed; no container/K8s manifests were modified, so no privilege settings could have been introduced.
No-Sensitive-Data-In-Logs ✅ Passed PR only changes go.mod/go.sum; no logging code or sensitive literals are present in the patch.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@smarthall

smarthall commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

Made ROSAENG-61788 to update the trickier dependencies we didn't update

@feichashao

Copy link
Copy Markdown
Contributor

/lgtm

Dependency updates for well known packages. CI is passing. No concern.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, smarthall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [feichashao,smarthall]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit dd8d0e3 into openshift:master Jul 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants