OCPBUGS-86849: Populate status label selector for scale subresource#1504
OCPBUGS-86849: Populate status label selector for scale subresource#1504RadekManak wants to merge 2 commits into
Conversation
Vendors openshift/api from cherry-pick-2807-to-release-4.20 branch (local replace) which adds LabelSelector to MachineSet status for the scale subresource (OCPBUGS-86849).
Cherry-pick of openshift#1490 to release-4.20. Fixes OCPBUGS-86849.
|
Skipping CI for Draft Pull Request. |
|
@RadekManak: This pull request references Jira Issue OCPBUGS-86849, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Backport of #1490 to release-4.20.
Fixes OCPBUGS-86849 (clone of OCPBUGS-82584 for release-4.20).
Populates
status.labelSelectoron MachineSet fromspec.selectorso the/scalesubresource exposes a valid selector string, enabling HPA and external autoscalers to work correctly.Depends on openshift/api#2866 (uses local replace for openshift/api until that PR merges).