Update module gopkg.in/evanphx/json-patch.v4 to v5#1638
Update module gopkg.in/evanphx/json-patch.v4 to v5#1638red-hat-konflux[bot] wants to merge 1 commit into
Conversation
|
/hold Revision a2087f2 was retested 3 times: holding |
a2087f2 to
0e3a91b
Compare
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
0e3a91b to
328d922
Compare
📝 WalkthroughWalkthroughThis PR updates a single indirect dependency in ChangesJSON Patch Dependency Upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 117: Remove the redundant gopkg.in module requirement and keep only the
canonical github module: delete the gopkg.in/evanphx/json-patch.v5 v5.9.11 entry
from go.mod, ensure github.com/evanphx/json-patch/v5 v5.9.11 remains, then run
go mod tidy (or otherwise update module files) so the go.sum/go.mod are
consistent and no gopkg.in reference remains.
- Line 117: The go.mod shows an indirect upgrade to
gopkg.in/evanphx/json-patch.v5 (gopkg.in/evanphx/json-patch.v5 v5.9.11 and
github.com/evanphx/json-patch/v5 v5.9.11) but there are no direct imports in the
repo; run a full dependency scan (go list -m all / search for
evanphx/json-patch) to confirm no direct usage, then run the complete test
matrix (unit and integration tests) to detect transitive breakages; if tests
fail, identify the dependent module pulling in json-patch.v5 and either update
that dependency to a compatible version or pin json-patch back to v4 via a
replace directive or vendor the compatible module until the transitive
dependency is fixed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2ee61b7f-f1e0-4c85-b348-7ceda1584809
📒 Files selected for processing (1)
go.mod
| google.golang.org/genproto/googleapis/rpc v0.0.0-20260511170946-3700d4141b60 // indirect | ||
| google.golang.org/grpc v1.81.1 // indirect | ||
| gopkg.in/evanphx/json-patch.v4 v4.13.0 // indirect | ||
| gopkg.in/evanphx/json-patch.v5 v5.9.11 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Identify why both gopkg.in and github.com paths exist for json-patch
# Check which dependencies require each path
echo "=== Dependencies requiring gopkg.in/evanphx/json-patch.v5 ==="
go mod graph | grep 'gopkg.in/evanphx/json-patch.v5'
echo -e "\n=== Dependencies requiring github.com/evanphx/json-patch/v5 ==="
go mod graph | grep 'github.com/evanphx/json-patch/v5'
echo -e "\n=== All references to json-patch in go.mod graph ==="
go mod graph | grep -i 'json-patch'Repository: openshift/lightspeed-operator
Length of output: 1487
🌐 Web query:
What is the correct import path for evanphx/json-patch v5? Is it gopkg.in/evanphx/json-patch.v5 or github.com/evanphx/json-patch/v5?
💡 Result:
The correct import path for evanphx/json-patch v5 is github.com/evanphx/json-patch/v5 [1][2]. According to the official project repository and documentation, you should use the following command to retrieve the library [1][3]: go get -u github.com/evanphx/json-patch/v5 The project previously used gopkg.in paths for versioning (e.g., gopkg.in/evanphx/json-patch.v4), but moved to the standard Go module structure using the /v5 suffix in the GitHub path [2][4]. Using the github.com/evanphx/json-patch/v5 path is the modern, recommended approach for all current versions [1][2][3].
Citations:
- 1: https://pkg.go.dev/github.com/evanphx/json-patch/v5@v5.9.11
- 2: https://github.com/evanphx/json-patch/blob/master/README.md
- 3: https://github.com/evanphx/json-patch
- 4: 'go get' fails evanphx/json-patch#102
Remove the redundant gopkg.in/evanphx/json-patch.v5 requirement and keep only github.com/evanphx/json-patch/v5
go.mod currently includes both gopkg.in/evanphx/json-patch.v5 v5.9.11 (line 117) and github.com/evanphx/json-patch/v5 v5.9.11 (existing entry). go mod graph shows only the root module pulls in the gopkg.in path; other deps require the github.com/.../v5 path. The project/docs for v5 recommend github.com/evanphx/json-patch/v5, so adding gopkg.in/.../v5 contradicts the stated “removed gopkg.in references” note.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 117, Remove the redundant gopkg.in module requirement and
keep only the canonical github module: delete the gopkg.in/evanphx/json-patch.v5
v5.9.11 entry from go.mod, ensure github.com/evanphx/json-patch/v5 v5.9.11
remains, then run go mod tidy (or otherwise update module files) so the
go.sum/go.mod are consistent and no gopkg.in reference remains.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Search for direct imports or usage of json-patch in the codebase
echo "=== Searching for json-patch imports ==="
rg -n --type=go 'import.*json-patch' -C2
echo -e "\n=== Searching for json-patch package usage ==="
rg -n --type=go 'jsonpatch\.' -C2
echo -e "\n=== Searching for gopkg.in/evanphx/json-patch imports ==="
rg -n --type=go 'gopkg\.in/evanphx/json-patch' -C2
echo -e "\n=== Searching for github.com/evanphx/json-patch imports ==="
rg -n --type=go 'github\.com/evanphx/json-patch' -C2Repository: openshift/lightspeed-operator
Length of output: 282
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== go.mod lines 100-140 ==="
nl -ba go.mod | sed -n '100,140p'
echo
echo "=== Search for json-patch references in entire repo ==="
rg -n 'json-patch|evanphx/json-patch|gopkg\.in/evanphx/json-patch|jsonpatch\.' -S
echo
echo "=== Search for module name in go.mod/go.sum specifically ==="
rg -n 'evanphx/json-patch|gopkg\.in/evanphx/json-patch' go.mod go.sum || true
echo
echo "=== Check if `go` tool is available (for `go mod why`) ==="
if command -v go >/dev/null 2>&1; then
go version
echo "=== go mod why gopkg.in/evanphx/json-patch ==="
go mod why -m gopkg.in/evanphx/json-patch || true
else
echo "go not available in this sandbox"
fiRepository: openshift/lightspeed-operator
Length of output: 163
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== go.mod lines 100-140 (no nl available) ==="
awk 'NR>=100 && NR<=140 {printf "%d\t%s\n", NR, $0}' go.mod
echo
echo "=== Search for json-patch references in entire repo ==="
rg -n 'json-patch|evanphx/json-patch|gopkg\.in/evanphx/json-patch|jsonpatch\.' -S || true
echo
echo "=== Search for module name in go.mod/go.sum specifically ==="
rg -n 'evanphx/json-patch|gopkg\.in/evanphx/json-patch' go.mod go.sum || true
echo
echo "=== Check if `go` tool is available (for `go mod why`) ==="
if command -v go >/dev/null 2>&1; then
go version
echo "=== go mod why gopkg.in/evanphx/json-patch ==="
go mod why -m gopkg.in/evanphx/json-patch || true
else
echo "go not available in this sandbox"
fiRepository: openshift/lightspeed-operator
Length of output: 16808
json-patch v4→v5 upgrade: no direct usage in this repo; only transitive risk remains.
- Searches show no Go source imports/usages of
json-patch/evanphx/json-patch(onlygo.mod/go.sumreferences). go.modincludesgopkg.in/evanphx/json-patch.v5 v5.9.11 // indirect(andgithub.com/evanphx/json-patch/v5 v5.9.11 // indirect), so impact is via transitive dependencies only.- Run the usual unit/integration tests to catch any transitive incompatibilities from the major bump.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 117, The go.mod shows an indirect upgrade to
gopkg.in/evanphx/json-patch.v5 (gopkg.in/evanphx/json-patch.v5 v5.9.11 and
github.com/evanphx/json-patch/v5 v5.9.11) but there are no direct imports in the
repo; run a full dependency scan (go list -m all / search for
evanphx/json-patch) to confirm no direct usage, then run the complete test
matrix (unit and integration tests) to detect transitive breakages; if tests
fail, identify the dependent module pulling in json-patch.v5 and either update
that dependency to a compatible version or pin json-patch back to v4 via a
replace directive or vendor the compatible module until the transitive
dependency is fixed.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v4.13.0→v5.9.11Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
evanphx/json-patch (gopkg.in/evanphx/json-patch.v4)
v5.9.11Compare Source
What's Changed
Full Changelog: evanphx/json-patch@v5.9.10...v5.9.11
v5.9.10Compare Source
What's Changed
New Contributors
Full Changelog: evanphx/json-patch@v5.9.0...v5.9.10
v5.9.0Compare Source
What's Changed
Full Changelog: evanphx/json-patch@v5.8.1...v5.9.0
v5.8.1: Fix API breakageCompare Source
This PR fixes Operation containing a reference to internal/json and breaking the ability to manually compose one. This restores that ability using a type alias.
Full Changelog: evanphx/json-patch@v5.8.0...v5.8.1
v5.8.0: Blargh Phixs and EmpathyprovementsCompare Source
This release fixes a few stray panics, addresses large number accuracy, and improves performance!
What's Changed
Full Changelog: evanphx/json-patch@v5.7.0...v5.8.0
v5.7.0: The 2023 ReleaseCompare Source
What's Changed
New Contributors
Full Changelog: evanphx/json-patch@v5.6.0...v5.7.0
v5.6.0: Bug fixesCompare Source
What's Changed
New Contributors
Full Changelog: evanphx/json-patch@v5.5.0...v5.6.0
v5.5.0: Better null handlingCompare Source
This incorporates a few fixes related to how nulls are handles in array's and objects.
v5.3.0: Fix zero sized document crashCompare Source
This fixes a crash bug where submitted an empty slice as the document would panic.
v5.2.0Compare Source
v5.1.0Compare Source
v5.0.0: Proper Go modules releaseCompare Source
This release has a proper /v5 directory, unlike the previous releases that did not have a /v4 dir. Thanks to @BenTheElder for getting this sorted out!
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.