Skip to content

Update module gopkg.in/evanphx/json-patch.v4 to v5#1638

Open
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x
Open

Update module gopkg.in/evanphx/json-patch.v4 to v5#1638
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x

Conversation

@red-hat-konflux
Copy link
Copy Markdown
Contributor

@red-hat-konflux red-hat-konflux Bot commented May 14, 2026

This PR contains the following updates:

Package Change Age Confidence
gopkg.in/evanphx/json-patch.v4 v4.13.0v5.9.11 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

evanphx/json-patch (gopkg.in/evanphx/json-patch.v4)

v5.9.11

Compare Source

What's Changed

Full Changelog: evanphx/json-patch@v5.9.10...v5.9.11

v5.9.10

Compare Source

What's Changed

New Contributors

Full Changelog: evanphx/json-patch@v5.9.0...v5.9.10

v5.9.0

Compare Source

What's Changed

Full Changelog: evanphx/json-patch@v5.8.1...v5.9.0

v5.8.1: Fix API breakage

Compare Source

This PR fixes Operation containing a reference to internal/json and breaking the ability to manually compose one. This restores that ability using a type alias.

Full Changelog: evanphx/json-patch@v5.8.0...v5.8.1

v5.8.0: Blargh Phixs and Empathyprovements

Compare Source

This release fixes a few stray panics, addresses large number accuracy, and improves performance!

What's Changed

Full Changelog: evanphx/json-patch@v5.7.0...v5.8.0

v5.7.0: The 2023 Release

Compare Source

What's Changed

New Contributors

Full Changelog: evanphx/json-patch@v5.6.0...v5.7.0

v5.6.0: Bug fixes

Compare Source

What's Changed

New Contributors

Full Changelog: evanphx/json-patch@v5.5.0...v5.6.0

v5.5.0: Better null handling

Compare Source

This incorporates a few fixes related to how nulls are handles in array's and objects.

v5.3.0: Fix zero sized document crash

Compare Source

This fixes a crash bug where submitted an empty slice as the document would panic.

v5.2.0

Compare Source

v5.1.0

Compare Source

v5.0.0: Proper Go modules release

Compare Source

This release has a proper /v5 directory, unlike the previous releases that did not have a /v4 dir. Thanks to @​BenTheElder for getting this sorted out!


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux red-hat-konflux Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 14, 2026
@openshift-ci openshift-ci Bot requested review from blublinsky and joshuawilson May 14, 2026 20:20
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD e95793d and 2 for PR HEAD a2087f2 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 16a2044 and 1 for PR HEAD a2087f2 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0ad58ba and 0 for PR HEAD a2087f2 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/hold

Revision a2087f2 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch from a2087f2 to 0e3a91b Compare May 27, 2026 04:23
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 27, 2026

New changes are detected. LGTM label has been removed.

@red-hat-konflux red-hat-konflux Bot changed the title Update module gopkg.in/evanphx/json-patch.v4 to v5 Update module gopkg.in/evanphx/json-patch.v4 to v5 - autoclosed May 28, 2026
@red-hat-konflux red-hat-konflux Bot closed this May 28, 2026
@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch May 28, 2026 00:30
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot changed the title Update module gopkg.in/evanphx/json-patch.v4 to v5 - autoclosed Update module gopkg.in/evanphx/json-patch.v4 to v5 May 28, 2026
@red-hat-konflux red-hat-konflux Bot reopened this May 28, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x branch 2 times, most recently from 0e3a91b to 328d922 Compare May 28, 2026 04:16
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

This PR updates a single indirect dependency in go.mod: gopkg.in/evanphx/json-patch is bumped from v4.13.0 to v5.9.11. The change involves replacing the v4 requirement with v5 in the module dependency list.

Changes

JSON Patch Dependency Upgrade

Layer / File(s) Summary
Update json-patch to v5
go.mod
The indirect dependency gopkg.in/evanphx/json-patch is upgraded from v4.13.0 to v5.9.11.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • joshuawilson
  • blublinsky
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: upgrading the json-patch module from v4 to v5, which matches the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/main/gopkg.in-evanphx-json-patch.v4-5.x

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 117: Remove the redundant gopkg.in module requirement and keep only the
canonical github module: delete the gopkg.in/evanphx/json-patch.v5 v5.9.11 entry
from go.mod, ensure github.com/evanphx/json-patch/v5 v5.9.11 remains, then run
go mod tidy (or otherwise update module files) so the go.sum/go.mod are
consistent and no gopkg.in reference remains.
- Line 117: The go.mod shows an indirect upgrade to
gopkg.in/evanphx/json-patch.v5 (gopkg.in/evanphx/json-patch.v5 v5.9.11 and
github.com/evanphx/json-patch/v5 v5.9.11) but there are no direct imports in the
repo; run a full dependency scan (go list -m all / search for
evanphx/json-patch) to confirm no direct usage, then run the complete test
matrix (unit and integration tests) to detect transitive breakages; if tests
fail, identify the dependent module pulling in json-patch.v5 and either update
that dependency to a compatible version or pin json-patch back to v4 via a
replace directive or vendor the compatible module until the transitive
dependency is fixed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2ee61b7f-f1e0-4c85-b348-7ceda1584809

📥 Commits

Reviewing files that changed from the base of the PR and between 15eaec5 and 328d922.

📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
google.golang.org/genproto/googleapis/rpc v0.0.0-20260511170946-3700d4141b60 // indirect
google.golang.org/grpc v1.81.1 // indirect
gopkg.in/evanphx/json-patch.v4 v4.13.0 // indirect
gopkg.in/evanphx/json-patch.v5 v5.9.11 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Identify why both gopkg.in and github.com paths exist for json-patch

# Check which dependencies require each path
echo "=== Dependencies requiring gopkg.in/evanphx/json-patch.v5 ==="
go mod graph | grep 'gopkg.in/evanphx/json-patch.v5'

echo -e "\n=== Dependencies requiring github.com/evanphx/json-patch/v5 ==="
go mod graph | grep 'github.com/evanphx/json-patch/v5'

echo -e "\n=== All references to json-patch in go.mod graph ==="
go mod graph | grep -i 'json-patch'

Repository: openshift/lightspeed-operator

Length of output: 1487


🌐 Web query:

What is the correct import path for evanphx/json-patch v5? Is it gopkg.in/evanphx/json-patch.v5 or github.com/evanphx/json-patch/v5?

💡 Result:

The correct import path for evanphx/json-patch v5 is github.com/evanphx/json-patch/v5 [1][2]. According to the official project repository and documentation, you should use the following command to retrieve the library [1][3]: go get -u github.com/evanphx/json-patch/v5 The project previously used gopkg.in paths for versioning (e.g., gopkg.in/evanphx/json-patch.v4), but moved to the standard Go module structure using the /v5 suffix in the GitHub path [2][4]. Using the github.com/evanphx/json-patch/v5 path is the modern, recommended approach for all current versions [1][2][3].

Citations:


Remove the redundant gopkg.in/evanphx/json-patch.v5 requirement and keep only github.com/evanphx/json-patch/v5
go.mod currently includes both gopkg.in/evanphx/json-patch.v5 v5.9.11 (line 117) and github.com/evanphx/json-patch/v5 v5.9.11 (existing entry). go mod graph shows only the root module pulls in the gopkg.in path; other deps require the github.com/.../v5 path. The project/docs for v5 recommend github.com/evanphx/json-patch/v5, so adding gopkg.in/.../v5 contradicts the stated “removed gopkg.in references” note.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 117, Remove the redundant gopkg.in module requirement and
keep only the canonical github module: delete the gopkg.in/evanphx/json-patch.v5
v5.9.11 entry from go.mod, ensure github.com/evanphx/json-patch/v5 v5.9.11
remains, then run go mod tidy (or otherwise update module files) so the
go.sum/go.mod are consistent and no gopkg.in reference remains.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Search for direct imports or usage of json-patch in the codebase

echo "=== Searching for json-patch imports ==="
rg -n --type=go 'import.*json-patch' -C2

echo -e "\n=== Searching for json-patch package usage ==="
rg -n --type=go 'jsonpatch\.' -C2

echo -e "\n=== Searching for gopkg.in/evanphx/json-patch imports ==="
rg -n --type=go 'gopkg\.in/evanphx/json-patch' -C2

echo -e "\n=== Searching for github.com/evanphx/json-patch imports ==="
rg -n --type=go 'github\.com/evanphx/json-patch' -C2

Repository: openshift/lightspeed-operator

Length of output: 282


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== go.mod lines 100-140 ==="
nl -ba go.mod | sed -n '100,140p'

echo
echo "=== Search for json-patch references in entire repo ==="
rg -n 'json-patch|evanphx/json-patch|gopkg\.in/evanphx/json-patch|jsonpatch\.' -S

echo
echo "=== Search for module name in go.mod/go.sum specifically ==="
rg -n 'evanphx/json-patch|gopkg\.in/evanphx/json-patch' go.mod go.sum || true

echo
echo "=== Check if `go` tool is available (for `go mod why`) ==="
if command -v go >/dev/null 2>&1; then
  go version
  echo "=== go mod why gopkg.in/evanphx/json-patch ==="
  go mod why -m gopkg.in/evanphx/json-patch || true
else
  echo "go not available in this sandbox"
fi

Repository: openshift/lightspeed-operator

Length of output: 163


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== go.mod lines 100-140 (no nl available) ==="
awk 'NR>=100 && NR<=140 {printf "%d\t%s\n", NR, $0}' go.mod

echo
echo "=== Search for json-patch references in entire repo ==="
rg -n 'json-patch|evanphx/json-patch|gopkg\.in/evanphx/json-patch|jsonpatch\.' -S || true

echo
echo "=== Search for module name in go.mod/go.sum specifically ==="
rg -n 'evanphx/json-patch|gopkg\.in/evanphx/json-patch' go.mod go.sum || true

echo
echo "=== Check if `go` tool is available (for `go mod why`) ==="
if command -v go >/dev/null 2>&1; then
  go version
  echo "=== go mod why gopkg.in/evanphx/json-patch ==="
  go mod why -m gopkg.in/evanphx/json-patch || true
else
  echo "go not available in this sandbox"
fi

Repository: openshift/lightspeed-operator

Length of output: 16808


json-patch v4→v5 upgrade: no direct usage in this repo; only transitive risk remains.

  • Searches show no Go source imports/usages of json-patch/evanphx/json-patch (only go.mod/go.sum references).
  • go.mod includes gopkg.in/evanphx/json-patch.v5 v5.9.11 // indirect (and github.com/evanphx/json-patch/v5 v5.9.11 // indirect), so impact is via transitive dependencies only.
  • Run the usual unit/integration tests to catch any transitive incompatibilities from the major bump.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 117, The go.mod shows an indirect upgrade to
gopkg.in/evanphx/json-patch.v5 (gopkg.in/evanphx/json-patch.v5 v5.9.11 and
github.com/evanphx/json-patch/v5 v5.9.11) but there are no direct imports in the
repo; run a full dependency scan (go list -m all / search for
evanphx/json-patch) to confirm no direct usage, then run the complete test
matrix (unit and integration tests) to detect transitive breakages; if tests
fail, identify the dependent module pulling in json-patch.v5 and either update
that dependency to a compatible version or pin json-patch back to v4 via a
replace directive or vendor the compatible module until the transitive
dependency is fixed.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raptorsun
Copy link
Copy Markdown
Contributor

/retest

4 similar comments
@raptorsun
Copy link
Copy Markdown
Contributor

/retest

@raptorsun
Copy link
Copy Markdown
Contributor

/retest

@raptorsun
Copy link
Copy Markdown
Contributor

/retest

@raptorsun
Copy link
Copy Markdown
Contributor

/retest

@raptorsun
Copy link
Copy Markdown
Contributor

/retest

2 similar comments
@raptorsun
Copy link
Copy Markdown
Contributor

/retest

@raptorsun
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 29, 2026

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-21 328d922 link true /test bundle-e2e-4-21
ci/prow/unit 328d922 link true /test unit
ci/prow/ci-index-lightspeed-bundle-test 328d922 link true /test ci-index-lightspeed-bundle-test
ci/prow/images 328d922 link true /test images
ci/prow/generate 328d922 link true /test generate
ci/prow/fips-image-scan-operator 328d922 link true /test fips-image-scan-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant