Update module go.yaml.in/yaml/v2 to v3#1637
Conversation
1772cf9 to
39547f3
Compare
|
New changes are detected. LGTM label has been removed. |
39547f3 to
de59261
Compare
|
/hold |
de59261 to
ac7a7ad
Compare
📝 WalkthroughWalkthroughThe PR updates the Go module manifest to replace the indirect YAML dependency ChangesYAML Library Upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 108-109: go.mod contains a duplicated module requirement
"go.yaml.in/yaml/v3 v3.0.4 // indirect"; remove one of the identical lines so
the dependency appears only once and then run go mod tidy to ensure the module
file is normalized; target the duplicate "go.yaml.in/yaml/v3 v3.0.4 // indirect"
entry when editing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c84fc84e-2061-4ad5-acd8-eebd226383f4
📒 Files selected for processing (1)
go.mod
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify duplicate go.yaml.in/yaml/v3 entries in go.mod
rg -n '^\s*go\.yaml\.in/yaml/v3\s+v3\.0\.4\b' go.mod
# Expected: exactly one match. Current diff shows two (Lines 108 and 109).Repository: openshift/lightspeed-operator
Length of output: 159
Remove duplicated go.yaml.in/yaml/v3 v3.0.4 // indirect entries from go.mod.
go.mod contains the exact same go.yaml.in/yaml/v3 v3.0.4 // indirect requirement twice (lines 108–109); keep only one to avoid go.mod hygiene/tooling issues.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 108 - 109, go.mod contains a duplicated module
requirement "go.yaml.in/yaml/v3 v3.0.4 // indirect"; remove one of the identical
lines so the dependency appears only once and then run go mod tidy to ensure the
module file is normalized; target the duplicate "go.yaml.in/yaml/v3 v3.0.4 //
indirect" entry when editing.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
ac7a7ad to
21a449f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v2.4.4→v3.0.4Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
yaml/go-yaml (go.yaml.in/yaml/v2)
v3.0.4Compare Source
v3.0.3Compare Source
v3.0.2Compare Source
v3.0.1Compare Source
v3.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.