Update patternfly to v6.5.1#2035
Conversation
📝 WalkthroughWalkthroughPatternFly dependencies in ChangesPatternFly Dependencies
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
95f432f to
44f5e58
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 27: The project currently pins "`@patternfly/chatbot`" at 6.6.0 which
requires React ^18/19 while the repo uses React 17; either upgrade the app to
React 18+ or change the dependency to the last React-17-compatible release
(replace "`@patternfly/chatbot`": "6.6.0" with the appropriate older version),
then run npm install and verify peerDependencies with npm ls and run the
app/tests to ensure the chatbot package works; locate the dependency by the
"`@patternfly/chatbot`" entry in package.json and update that version accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 89a12c20-09a9-4a0f-a6c3-2831c35492aa
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "@patternfly/react-code-editor": "6.4.3", | ||
| "@patternfly/react-core": "6.4.3", | ||
| "@patternfly/react-icons": "6.4.0", | ||
| "@patternfly/chatbot": "6.6.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify peer-dependency compatibility between package.json pins and resolved lockfile packages.
set -euo pipefail
echo "== React pins in package.json =="
jq -r '.dependencies.react, .dependencies["react-dom"], .overrides.react, .overrides["react-dom"]' package.json
echo
echo "== PatternFly chatbot peerDependencies from lockfile =="
jq -r '.packages["node_modules/@patternfly/chatbot"].peerDependencies' package-lock.json
echo
echo "== PatternFly versions currently resolved =="
jq -r '.packages[""].dependencies
| {chatbot: .["`@patternfly/chatbot`"], code_editor: .["`@patternfly/react-code-editor`"], core: .["`@patternfly/react-core`"], icons: .["`@patternfly/react-icons`"]}' package-lock.jsonRepository: openshift/lightspeed-console
Length of output: 449
@patternfly/chatbot@6.6.0 has peer-dependency conflict with React 17
@patternfly/chatbot on package.json line 27 is 6.6.0, whose peerDependencies require react/react-dom ^18 || ^19. This repo pins react and react-dom to 17.0.2 (dependencies + overrides), so npm peer resolution is likely to warn/error and the package may not function correctly.
Suggested direction
- "`@patternfly/chatbot`": "6.6.0",
+ "`@patternfly/chatbot`": "<last React-17-compatible version>",If upgrading to React 18+ is out of scope, keep chatbot on the last React-17-compatible release.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 27, The project currently pins "`@patternfly/chatbot`" at
6.6.0 which requires React ^18/19 while the repo uses React 17; either upgrade
the app to React 18+ or change the dependency to the last React-17-compatible
release (replace "`@patternfly/chatbot`": "6.6.0" with the appropriate older
version), then run npm install and verify peerDependencies with npm ls and run
the app/tests to ensure the chatbot package works; locate the dependency by the
"`@patternfly/chatbot`" entry in package.json and update that version accordingly.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
44f5e58 to
14b6a07
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
6.4.3→6.5.16.4.3→6.5.16.4.0→6.5.1Release Notes
patternfly/patternfly-react (@patternfly/react-code-editor)
v6.5.1Compare Source
v6.5.0Compare Source
What's Changed
New Contributors
Full Changelog: patternfly/patternfly-react@v6.4.0...v6.5.0
Configuration
📅 Schedule: Branch creation - Every minute ( * * * * * ) in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.