OCPBUGS-112324: [release-4.20]: Enrich IBI config image proxy NoProxy with cluster networks by mlorenzofr · Pull Request #10779 · openshift/installer

mlorenzofr · 2026-08-20T09:25:35Z

This PR fixes OCPBUGS-112324 by enriching the IBI proxy NoProxy configuration with internal cluster network CIDRs and the internal API server hostname, ensuring that internal cluster traffic bypasses the proxy.

Remove the Networking asset dependency from createNoProxy and use installConfig directly for ClusterNetwork, matching the existing approach for ServiceNetwork and MachineNetwork. The Networking asset performs no business logic on ClusterNetwork data, only type conversion from ipnet.IPNet to string. Using installConfig directly for all three network types makes the code more consistent and removes an unnecessary dependency.

These changes align how the NoProxy variable is enriched in the IBI installation with the method used in normal installations. Extract BuildNoProxySet into pkg/types so the manifests proxy asset and the IBI config image asset share the same NoProxy building logic. Update tests accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-08-20T09:25:38Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-20T09:25:42Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-60993, which is invalid:

expected the bug to target either version "4.20.z." or "openshift-4.20.z.", but it targets "5.1.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-60993 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR fixes OCPBUGS-60993 by enriching the IBI proxy NoProxy configuration with internal cluster network CIDRs and the internal API server hostname, ensuring that internal cluster traffic bypasses the proxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-20T09:25:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aa8b415a-9df2-4e20-8215-0beaadd81ac8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-20T09:29:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mlorenzofr · 2026-08-20T09:46:54Z

/jira refresh

openshift-ci-robot · 2026-08-20T09:46:58Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-60993, which is invalid:

expected the bug to target only the "4.20.z" version, but multiple target versions were set
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-60993 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-08-20T09:52:29Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-112321, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-112321 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR fixes OCPBUGS-60993 by enriching the IBI proxy NoProxy configuration with internal cluster network CIDRs and the internal API server hostname, ensuring that internal cluster traffic bypasses the proxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mlorenzofr · 2026-08-20T10:07:10Z

/jira refresh

openshift-ci-robot · 2026-08-20T10:07:14Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-112321, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-112321 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mlorenzofr · 2026-08-20T10:08:41Z

/jira refresh

openshift-ci-robot · 2026-08-20T10:08:46Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-112321, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-112321 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mlorenzofr · 2026-08-20T10:10:13Z

/jira refresh

openshift-ci-robot · 2026-08-20T10:10:19Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-112321, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-08-20T10:48:38Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-112321, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Duplicate) instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This PR fixes OCPBUGS-112324 by enriching the IBI proxy NoProxy configuration with internal cluster network CIDRs and the internal API server hostname, ensuring that internal cluster traffic bypasses the proxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-08-20T10:48:47Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-112324, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR fixes OCPBUGS-112324 by enriching the IBI proxy NoProxy configuration with internal cluster network CIDRs and the internal API server hostname, ensuring that internal cluster traffic bypasses the proxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mlorenzofr · 2026-08-20T11:05:49Z

/retest-required
/jira refresh

openshift-ci-robot · 2026-08-20T11:05:56Z

@mlorenzofr: This pull request references Jira Issue OCPBUGS-112324, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-60993 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-60993 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (gpei@redhat.com), skipping review request.

Details

In response to this:

/retest-required
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mlorenzofr · 2026-08-20T14:00:23Z

/retest-required

mlorenzofr · 2026-08-20T15:58:25Z

/retest-required

mlorenzofr · 2026-08-21T07:57:30Z

/retest-required

openshift-ci · 2026-08-21T08:53:23Z

@mlorenzofr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	`8148ff3`	link	true	`/test images`
ci/prow/integration-tests	`8148ff3`	link	true	`/test integration-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

carbonin and others added 2 commits August 20, 2026 10:55

openshift-ci Bot requested review from andfasano and javipolo August 20, 2026 09:28

mlorenzofr changed the title ~~OCPBUGS-60993: [release-4.20]: Enrich IBI config image proxy NoProxy with cluster networks~~ OCPBUGS-112321: [release-4.20]: Enrich IBI config image proxy NoProxy with cluster networks Aug 20, 2026

openshift-ci-robot removed the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Aug 20, 2026

mlorenzofr changed the title ~~OCPBUGS-112321: [release-4.20]: Enrich IBI config image proxy NoProxy with cluster networks~~ OCPBUGS-112324: [release-4.20]: Enrich IBI config image proxy NoProxy with cluster networks Aug 20, 2026

openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Aug 20, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 20, 2026

Uh oh!

Conversation

mlorenzofr commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

coderabbitai Bot commented Aug 20, 2026

Review skipped

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 20, 2026

Uh oh!

openshift-ci-robot commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 20, 2026

Uh oh!

mlorenzofr commented Aug 21, 2026

Uh oh!

openshift-ci Bot commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mlorenzofr commented Aug 20, 2026 •

edited

Loading