CONSOLE-5434: Replace Popper with PF components#16831
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@logonoff: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci
Bot
added
component/core
|
/label px-approved |
openshift-ci
Bot
added
px-approved
openshift-ci-robot
added
the
verified
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (25)
💤 Files with no reviewable changes (9)
🚧 Files skipped from review as they are similar to previous changes (12)
WalkthroughThe change removes legacy Popper-based overlays, adopts PatternFly Tooltip and Popover APIs, renders spotlights through direct React portals, updates guided-tour placement typing, and adjusts integration-test selectors. ChangesOverlay and guided-tour migration
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant GuidedTour
participant TourStepComponent
participant PatternFlyPopover
GuidedTour->>TourStepComponent: provide PopoverPosition placement
TourStepComponent->>PatternFlyPopover: pass position and visibility callbacks
PatternFlyPopover->>TourStepComponent: invoke shouldClose
TourStepComponent->>GuidedTour: route closure through handleClose
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@logonoff: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pipeline required |
|
Scheduling tests matching the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@frontend/packages/console-shared/src/components/markdown-extensions/MarkdownExecuteSnippet.tsx`:
- Around line 37-43: Update the event-listener setup in MarkdownExecuteSnippet
so the data-executed attribute is also removed when the button receives keyboard
focus, while preserving the existing mouseenter behavior. Add a regression test
covering focus-triggered reset for the keyboard-focusable button.
In
`@frontend/packages/console-shared/src/components/spotlight/InteractiveSpotlight.tsx`:
- Around line 20-29: Update InteractiveSpotlight so the target rectangle is
stored and refreshed rather than read only once during render. Recalculate
element.getBoundingClientRect() after the spotlight’s scrolling effect and on
relevant scroll and resize events, then derive the fixed-position style from the
latest rectangle so the highlight stays aligned with element.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4aff08d6-d869-4e3d-8be4-041c8fbe779b
⛔ Files ignored due to path filters (1)
frontend/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (23)
frontend/package.jsonfrontend/packages/console-app/src/components/guided-tour/index.tsxfrontend/packages/console-app/src/components/tour/StepComponent.tsxfrontend/packages/console-app/src/components/tour/TourStepComponent.tsxfrontend/packages/console-app/src/components/tour/__tests__/TourStepComponent.spec.tsxfrontend/packages/console-app/src/components/tour/type.tsfrontend/packages/console-shared/src/components/Tooltip/Tooltip.scssfrontend/packages/console-shared/src/components/Tooltip/Tooltip.tsxfrontend/packages/console-shared/src/components/markdown-extensions/MarkdownCopyClipboard.tsxfrontend/packages/console-shared/src/components/markdown-extensions/MarkdownExecuteSnippet.tsxfrontend/packages/console-shared/src/components/markdown-extensions/inline-execute-extension.tsfrontend/packages/console-shared/src/components/markdown-extensions/multiline-execute-extension.tsfrontend/packages/console-shared/src/components/popover/Popover.scssfrontend/packages/console-shared/src/components/popover/Popover.tsxfrontend/packages/console-shared/src/components/popover/const.tsfrontend/packages/console-shared/src/components/popper/Popper.tsxfrontend/packages/console-shared/src/components/popper/Portal.tsxfrontend/packages/console-shared/src/components/popper/Tippy.tsxfrontend/packages/console-shared/src/components/spotlight/InteractiveSpotlight.tsxfrontend/packages/console-shared/src/components/spotlight/StaticSpotlight.tsxfrontend/packages/dev-console/integration-tests/support/pageObjects/gettingStarted-po.tsfrontend/packages/dev-console/integration-tests/support/step-definitions/quck-starts/quick-start-access-code-snippet.tsfrontend/packages/dev-console/src/components/guided-tour/index.tsx
💤 Files with no reviewable changes (8)
- frontend/packages/console-shared/src/components/popover/Popover.scss
- frontend/packages/console-shared/src/components/popover/const.ts
- frontend/packages/console-shared/src/components/Tooltip/Tooltip.scss
- frontend/packages/console-shared/src/components/popover/Popover.tsx
- frontend/packages/console-shared/src/components/Tooltip/Tooltip.tsx
- frontend/packages/console-shared/src/components/popper/Tippy.tsx
- frontend/packages/console-shared/src/components/popper/Portal.tsx
- frontend/packages/console-shared/src/components/popper/Popper.tsx
openshift-ci-robot
removed
the
verified
logonoff
changed the title
|
@logonoff: This pull request references CONSOLE-5434 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pipeline required |
|
Scheduling tests matching the |
openshift-ci-robot
added
the
verified
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
verified
|
/pipeline required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling tests matching the |
openshift-ci-robot
added
the
verified
|
@logonoff: This pull request references CONSOLE-5434 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage. |
704fb3a
into
openshift:main
3 participants
Analysis / Root cause:
Popper.js is deprecated:
Solution description:
Replace it with the PatternFly equivalent components
Screenshots / screen recording:
No UI changes
Test setup:
Test cases:
Browser conformance:
Summary by CodeRabbit
Bug Fixes
Refactor
Tests
Chores