Skip to content

OCPBUGS-99491: Fix Installed Operators table row cells ignoring column management#16817

Open
TheRealJon wants to merge 1 commit into
openshift:mainfrom
TheRealJon:OCPBUGS-99491
Open

OCPBUGS-99491: Fix Installed Operators table row cells ignoring column management#16817
TheRealJon wants to merge 1 commit into
openshift:mainfrom
TheRealJon:OCPBUGS-99491

Conversation

@TheRealJon

@TheRealJon TheRealJon commented Jul 23, 2026

Copy link
Copy Markdown
Member

Analysis / Root cause:
ClusterServiceVersionTableRow and SubscriptionTableRow rendered <TableData> cells without columnID or columns props. The isColumnVisible() function in table.tsx returns true when no columns Set is provided, so all row cells stayed visible regardless of column management selections. Headers worked correctly because getActiveColumns() filters the column array at the Table component level.

Solution description:

  • InstalledOperatorTableRow now destructures the columns array from RowFunctionArgs and converts it to a Set<string> of active column IDs
  • Both ClusterServiceVersionTableRow and SubscriptionTableRow receive activeColumnIDs and pass columnID + columns props to each <TableData> cell
  • Kebab column intentionally left without these props — it has no id in its header definition and should always be visible

Screenshots / screen recording:
Before

Screen.Recording.2026-07-23.at.3.37.43.PM.mov

After

Screen.Recording.2026-07-23.at.3.38.35.PM.mov

Test setup:

  1. Install an operator via OperatorHub
  2. Navigate to Operators > Installed Operators

Test cases:

  • Open column management modal, uncheck a column (e.g., "Status"), save → column header AND row cells should hide
  • Check an additional column, save → column header AND row cells should appear
  • Restore default columns → table returns to default layout
  • Switch between single project and all-namespaces → namespace column visibility correct

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
OCPBUGS-99491

Summary by CodeRabbit

  • New Features

    • Installed Operators table rows now respond to column management selections.
    • Users can show or hide supported columns consistently across operator and subscription details.
  • Improvements

    • Column visibility is now applied across operator name, namespace, status, APIs, compatibility, support phase, and last updated information.

…table rows

Row cells on the Installed Operators page were not responding to column
management selections because TableData components were rendered without
columnID or columns props. Without these, isColumnVisible() always returns
true, so all cells stayed visible regardless of user column selections.
Headers worked correctly because getActiveColumns() filters at the Table
component level.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@TheRealJon: This pull request references Jira Issue OCPBUGS-99491, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:
ClusterServiceVersionTableRow and SubscriptionTableRow rendered <TableData> cells without columnID or columns props. The isColumnVisible() function in table.tsx returns true when no columns Set is provided, so all row cells stayed visible regardless of column management selections. Headers worked correctly because getActiveColumns() filters the column array at the Table component level.

Solution description:

  • InstalledOperatorTableRow now destructures the columns array from RowFunctionArgs and converts it to a Set<string> of active column IDs
  • Both ClusterServiceVersionTableRow and SubscriptionTableRow receive activeColumnIDs and pass columnID + columns props to each <TableData> cell
  • Kebab column intentionally left without these props — it has no id in its header definition and should always be visible

Screenshots / screen recording:
TODO: Add before/after screenshots

Test setup:

  1. Install an operator via OperatorHub
  2. Navigate to Operators > Installed Operators

Test cases:

  • Open column management modal, uncheck a column (e.g., "Status"), save → column header AND row cells should hide
  • Check an additional column, save → column header AND row cells should appear
  • Restore default columns → table returns to default layout
  • Switch between single project and all-namespaces → namespace column visibility correct

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
OCPBUGS-99491

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Installed operator table rows now derive active column selections and pass them to CSV and subscription rows. Name, namespace, status, API, compatibility, support, managed namespace, and timestamp cells now bind to column management.

Changes

Installed Operator column management

Layer / File(s) Summary
Propagate active column selections
frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
InstalledOperatorTableRow derives active column IDs from configured columns and passes them to CSV and subscription row components.
Bind table cells to active columns
frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx
Relevant TableData cells receive matching columnID values and columns={activeColumnIDs} for both row types.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant InstalledOperatorTableRow
  participant ClusterServiceVersionTableRow
  participant SubscriptionTableRow
  participant TableData
  InstalledOperatorTableRow->>InstalledOperatorTableRow: derive activeColumnIDs from columns
  InstalledOperatorTableRow->>ClusterServiceVersionTableRow: pass activeColumnIDs for CSV rows
  InstalledOperatorTableRow->>SubscriptionTableRow: pass activeColumnIDs for subscription rows
  ClusterServiceVersionTableRow->>TableData: render cells with columnID and activeColumnIDs
  SubscriptionTableRow->>TableData: render cells with columnID and activeColumnIDs
Loading

Suggested labels: component/core

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only changes a component file; no test files or Ginkgo titles were added or modified, and no It/Describe/Context/When constructs appear in the diff.
Test Structure And Quality ✅ Passed PR changes only a TSX component file; no Ginkgo or test code was modified, so the test-structure checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only a frontend component changed; the diff adds no Ginkgo e2e tests or MicroShift-sensitive APIs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a frontend component file changed; no new Ginkgo/e2e tests were added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only UI table-row rendering changed; no pod specs, schedulers, node selectors, anti-affinity, or topology logic were added.
Ote Binary Stdout Contract ✅ Passed Only a frontend table-row component changed; no main/init/TestMain/suite setup or stdout logging was added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR changes only a frontend table-row component; no new Ginkgo e2e tests or IPv4/external-network assumptions were added.
No-Weak-Crypto ✅ Passed Diff only updates operator table column visibility wiring; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed Only a TSX table-row component changed; no container/K8s manifests or securityContext settings (privileged, hostPID, hostNetwork, hostIPC, allowPrivilegeEscalation) were modified.
No-Sensitive-Data-In-Logs ✅ Passed No new logging was added; the diff only updates table cell column props, and existing console.error messages are generic, not sensitive.
Title check ✅ Passed The title is specific, concise, and matches the main fix for Installed Operators column management.
Description check ✅ Passed The description covers the required analysis, solution, screenshots, test setup, test cases, and extra info; only reviewers/assignees is missing.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Leo6Leo and jhadvig July 23, 2026 19:38
@openshift-ci openshift-ci Bot added the component/olm Related to OLM label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/backend c88331d link true /test backend

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants