Skip to content

OCPBUGS-88416 OCPBUGS-88398: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with old version of TS#16793

Open
rhdmalone wants to merge 1 commit into
openshift:release-4.12from
rhdmalone:release-4.12-260721
Open

OCPBUGS-88416 OCPBUGS-88398: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with old version of TS#16793
rhdmalone wants to merge 1 commit into
openshift:release-4.12from
rhdmalone:release-4.12-260721

Conversation

@rhdmalone

@rhdmalone rhdmalone commented Jul 21, 2026

Copy link
Copy Markdown

OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with an older version of TypeScript
Fixes CVE-2026-44486.
https://redhat.atlassian.net/browse/OCPBUGS-88416

How this patch was generated:
Step 1:
From frontend/:

Point deps at unpatched 0.33.0 temporarily i.e. In frontend/package.json:
Dependency:
"axios": "0.33.0"

Step 2:
cd frontend
yarn install
yarn patch axios@npm:0.33.0
Yarn prints a temp folder path.

For example:

yarn patch axios@npm:0.33.0
➤ YN0000: Package axios@npm:0.33.0 got extracted with success!
➤ YN0000: You can now edit the following folder: /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
➤ YN0000: Once you are done run yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user and Yarn will store a patchfile based on your changes.
➤ YN0000: Done in 0s 23ms

Apply the same TypeScript fix in that folder’s index.d.ts
For example:
get the directory that is listed e.g./private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-8bb6f632/user
in that folder, edit and save the file index.d.ts
replace
type MethodsHeaders = {
[Key in Method as Lowercase]: AxiosHeaders;
};
with
type LowercaseMethod =
| 'get' | 'delete' | 'head' | 'options' | 'post'
| 'put' | 'patch' | 'purge' | 'link' | 'unlink';

type MethodsHeaders = {
[Key in LowercaseMethod]?: AxiosHeaders;
};

Step 3:
Apply changes:
yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
yarn install
yarn build

Step 4:
Add and commit changes etc
to determine the name of the patch, find it in the folder .yarn/patches - it will start with the name axios-npm-0.33.0

git add .yarn/patches/axios-npm-0.33.0-023deda7e4.patch
git add package.json
git add yarn.lock
git commit -m "OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with older version of TypeScript"
git push

Testing
in the main console folder,
Test 1
./build-frontend.sh > test-4.12.axios-bump.txt
The output file was anlaysed by Claude:
Verdict: PASS — ./build-frontend.sh succeeded on release-4.12-260721 with the axios 0.33.0 Yarn type patch.

Test 2
./build-demos.sh > test-4.12-build-demos.txt
The output file was anlaysed by Claude:
Verdict: PASS - webpack 5.73.0 compiled successfully in 5628 ms

…axios 0.33.0 types to be compatible with older version of TypeScript
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhdmalone: This pull request references Jira Issue OCPBUGS-88416, which is invalid:

  • expected dependent Jira Issue OCPBUGS-88410 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with an older version of TypeScript
Fixes CVE-2026-44486.
https://redhat.atlassian.net/browse/OCPBUGS-88416

How this patch was generated:
Step 1:
From frontend/:

Point deps at unpatched 0.33.0 temporarily i.e. In frontend/package.json:
Dependency:
"axios": "0.33.0"

Step 2:
cd frontend
yarn install
yarn patch axios@npm:0.33.0
Yarn prints a temp folder path.

For example:

yarn patch axios@npm:0.33.0
➤ YN0000: Package axios@npm:0.33.0 got extracted with success!
➤ YN0000: You can now edit the following folder: /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
➤ YN0000: Once you are done run yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user and Yarn will store a patchfile based on your changes.
➤ YN0000: Done in 0s 23ms

Apply the same TypeScript fix in that folder’s index.d.ts
For example:
get the directory that is listed e.g./private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-8bb6f632/user
in that folder, edit and save the file index.d.ts
replace
type MethodsHeaders = {
[Key in Method as Lowercase]: AxiosHeaders;
};
with
type LowercaseMethod =
| 'get' | 'delete' | 'head' | 'options' | 'post'
| 'put' | 'patch' | 'purge' | 'link' | 'unlink';

type MethodsHeaders = {
[Key in LowercaseMethod]?: AxiosHeaders;
};

Step 3:
Apply changes:
yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
yarn install
yarn build

Step 4:
Add and commit changes etc
to determine the name of the patch, find it in the folder .yarn/patches - it will start with the name axios-npm-0.33.0

git add .yarn/patches/axios-npm-0.33.0-023deda7e4.patch
git add package.json
git add yarn.lock
git commit -m "OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with older version of TypeScript"
git push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7582c43e-6876-4e8c-82af-5507ab9aeeb4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from cajieh and rhamilto July 21, 2026 16:53
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhdmalone
Once this PR has been reviewed and has the lgtm label, please assign vojtechszocs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@rhdmalone: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Pranavgarud06

Copy link
Copy Markdown
Contributor

/retitle OCPBUGS-88416 OCPBUGS-88398: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with old version of TS
#16793

@openshift-ci openshift-ci Bot changed the title OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with old version of TS OCPBUGS-88416 OCPBUGS-88398: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with old version of TS Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rhdmalone: This pull request references Jira Issue OCPBUGS-88416, which is invalid:

  • expected dependent Jira Issue OCPBUGS-88410 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-88398, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-88391 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-88391 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with an older version of TypeScript
Fixes CVE-2026-44486.
https://redhat.atlassian.net/browse/OCPBUGS-88416

How this patch was generated:
Step 1:
From frontend/:

Point deps at unpatched 0.33.0 temporarily i.e. In frontend/package.json:
Dependency:
"axios": "0.33.0"

Step 2:
cd frontend
yarn install
yarn patch axios@npm:0.33.0
Yarn prints a temp folder path.

For example:

yarn patch axios@npm:0.33.0
➤ YN0000: Package axios@npm:0.33.0 got extracted with success!
➤ YN0000: You can now edit the following folder: /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
➤ YN0000: Once you are done run yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user and Yarn will store a patchfile based on your changes.
➤ YN0000: Done in 0s 23ms

Apply the same TypeScript fix in that folder’s index.d.ts
For example:
get the directory that is listed e.g./private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-8bb6f632/user
in that folder, edit and save the file index.d.ts
replace
type MethodsHeaders = {
[Key in Method as Lowercase]: AxiosHeaders;
};
with
type LowercaseMethod =
| 'get' | 'delete' | 'head' | 'options' | 'post'
| 'put' | 'patch' | 'purge' | 'link' | 'unlink';

type MethodsHeaders = {
[Key in LowercaseMethod]?: AxiosHeaders;
};

Step 3:
Apply changes:
yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
yarn install
yarn build

Step 4:
Add and commit changes etc
to determine the name of the patch, find it in the folder .yarn/patches - it will start with the name axios-npm-0.33.0

git add .yarn/patches/axios-npm-0.33.0-023deda7e4.patch
git add package.json
git add yarn.lock
git commit -m "OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with older version of TypeScript"
git push

Testing
in the main console folder,
Test 1
./build-frontend.sh > test-4.12.axios-bump.txt
The output file was anlaysed by Claude:
Verdict: PASS — ./build-frontend.sh succeeded on release-4.12-260721 with the axios 0.33.0 Yarn type patch.

Test 2
./build-demos.sh > test-4.12-build-demos.txt
The output file was anlaysed by Claude:
Verdict: PASS - webpack 5.73.0 compiled successfully in 5628 ms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants