Skip to content

Add Helm 3 CLI download links alongside Helm 4 - #1197

Open
sowmya-sl wants to merge 1 commit into
openshift:mainfrom
sowmya-sl:helm-ocp-5-rel
Open

Add Helm 3 CLI download links alongside Helm 4#1197
sowmya-sl wants to merge 1 commit into
openshift:mainfrom
sowmya-sl:helm-ocp-5-rel

Conversation

@sowmya-sl

@sowmya-sl sowmya-sl commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Helm 3 remains available for existing workflows. This adds a separate ConsoleCLIDownload resource so both versions appear on the CLI downloads page.

image

Reviewers and assignees:

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Added Helm 3 CLI download information, including updated metadata and a link to the latest Helm 3 client bundle.
  • Bug Fixes
    • Updated the existing Helm 4 CLI download link to the latest Helm 4 client bundle.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Walkthrough

Updates the Helm 4 CLI bundle URL and adds a ConsoleCLIDownload resource for Helm 3 with Helm-specific metadata and a latest client bundle link.

Changes

Helm CLI download resources

Layer / File(s) Summary
Helm CLI download resources
manifests/07-downloads-helm.yaml
Updates the Helm 4 link to version 4.2.3 and adds the helm3-download-links resource with Helm 3 metadata and the latest client bundle URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning Most required template sections are missing, so the PR description is too incomplete for review. Fill in Analysis/Root cause, Solution description, Test setup, Test cases, Browser conformance, Additional info, and reviewers/assignees.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo tests were added or edited; the PR only changes a Helm CLI manifest, so there are no test titles to vet.
Test Structure And Quality ✅ Passed PR only changes a YAML manifest; no Ginkgo test code, setup/cleanup, timeouts, or assertion patterns are involved.
Microshift Test Compatibility ✅ Passed PR only changes manifests/07-downloads-helm.yaml; no new Ginkgo tests or MicroShift-unsupported test code were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only manifests/07-downloads-helm.yaml changed; no Ginkgo e2e tests were added, so SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ConsoleCLIDownload content changed; no pods, controllers, node selectors, affinity, or PDBs were added.
Ote Binary Stdout Contract ✅ Passed PR only changes a YAML manifest; no process-level code or stdout writes were added, so the stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a Helm CLI download manifest changed; no Ginkgo e2e tests or IPv4/external-network assumptions were added.
No-Weak-Crypto ✅ Passed PASS: The PR only updates a YAML manifest for Helm download links; no weak crypto, custom crypto, or secret/token comparisons are introduced.
Container-Privileges ✅ Passed The changed manifest only defines ConsoleCLIDownload resources; no privileged, hostPID/network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs ✅ Passed Only a manifest YAML changed; scans found no logging statements or sensitive data in the touched file.
Title check ✅ Passed The title accurately summarizes the main change: adding Helm 3 CLI download links alongside Helm 4.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@webbnh webbnh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, but I've got a suggestion, a question, and a proposed revision (I'll let you guess which is which 😉).

/lgtm

Comment thread manifests/07-downloads-helm.yaml Outdated
@@ -16,3 +16,22 @@ spec:
links:
- href: 'https://mirror.openshift.com/pub/cgw/helm/4.1.4'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating this to 4.2.3.

(Presumably, this would be better done in a separate PR, but the additional hassle doesn't seem worthwhile, given the narrow scope and low complexity of this PR.)

Comment on lines +32 to +33
Helm 3 is a package manager for Kubernetes that simplifies deploying and managing
applications using Helm Charts. Helm 3 remains available for existing workflows.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, why does the first sentence use verbiage different from the Helm 4 text?

Regardless, given that we're including that second sentence, we might want to go all-in and say something like "Helm 3 continues to be provided for operational continuity, but it will not be compatible with future releases of OCP and so customers are encouraged to upgrade to Helm 4." (I suggest conferring with Marina and Jocelyn on detailed content and wording.)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we are concerned that having it on the console will imply support, we simply should redirect to the compatibility matrix then: https://access.redhat.com/articles/7145580 .
I would say, under both sections:
For Helm CLI compatibility with OpenShift releases refer to article https://access.redhat.com/articles/7145580.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are concerned that having it on the console will imply support

@mkumku, we expect that this documentation is version-specific -- e.g., the change proposed here is specifically for OCP 5.0. We will backport this change to OCP 4.22, and presumably it will propagate automatically to OCP 4.23. For OCP 5.2 (and, perhaps for 5.1), we will remove the Helm v3 section.

So, while I have no objection to adding a reference to a support statement, I don't think it's necessary; and, I don't think it's really useful to make a statement about compatibility -- what we are advertising here is supposed to be compatible with the platform where it is being advertised!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how these changes relate to the content served from https://console.redhat.com/openshift/downloads -- that content seems to be version independent, which poses exactly the compatibility challenges that you are raising. If that content comes from here, then, yeah, we definitely need pointers from here to both compatibility and support documentation. 😛

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sowmya-sl, webbnh
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Helm 3 remains available for existing workflows. This adds a
separate ConsoleCLIDownload resource so both versions appear
on the CLI downloads page.

Update Helm 4 latest link.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2026
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@sowmya-sl
sowmya-sl marked this pull request as ready for review July 27, 2026 10:37
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2026
@openshift-ci
openshift-ci Bot requested review from TheRealJon and jhadvig July 27, 2026 10:37
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@sowmya-sl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade b16ee7e link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants