Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ spec:
matchLabels:
app: cluster-update-console-plugin
ingress:
- ports:
- from:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything here about why @jhadvig didn't tune access like this (or even more tightly, can't we also match the app: console label?).

But also, the long-established monitoring ConsolePlugin doesn't bother to set from for their ConsolePlugin, so 🤷, doesn't seem like a particularly sensitive thing to protect.

- namespaceSelector:
matchLabels:
kubernetes.io/metadata.name: openshift-console
ports:
- port: 9001
protocol: TCP
policyTypes:
Expand Down