Skip to content

NO-JIRA: Yarn update and hermetic builds#6

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
wking:yarn-update-and-hermetic-builds
May 1, 2026
Merged

NO-JIRA: Yarn update and hermetic builds#6
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
wking:yarn-update-and-hermetic-builds

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented May 1, 2026

Trying out openshift/console-plugin-template#107 into this repo to test hermetic builds

- Update yarn to latest
- Update yarn config to align with upstream (e.g., disableScripts except for cypress)
@openshift-ci openshift-ci Bot requested review from DavidHurta and hongkailiu May 1, 2026 20:05
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2026
Copy link
Copy Markdown
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@logonoff
Copy link
Copy Markdown
Member

logonoff commented May 1, 2026

/retitle NO-JIRA: Yarn update and hermetic builds

@openshift-ci openshift-ci Bot changed the title Yarn update and hermetic builds NO-JIRA: Yarn update and hermetic builds May 1, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@wking: This pull request explicitly references no jira issue.

Details

In response to this:

Trying out openshift/console-plugin-template#107 into this repo to test hermetic builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Resolving the yarn.lock conflicts with:

  $ node .yarn/releases/yarn-4.14.1.cjs install

using:

  $ node --version
  v22.22.0
@wking wking force-pushed the yarn-update-and-hermetic-builds branch from 653b733 to 18fe5e9 Compare May 1, 2026 20:33
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 1, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 1, 2026

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff
Copy link
Copy Markdown
Member

logonoff commented May 1, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2026
@wking
Copy link
Copy Markdown
Member Author

wking commented May 1, 2026

/verified by @wking, nobody is consuming this yet, so nothing worth testing

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@wking: This PR has been marked as verified by @wking,nobody is consuming this yet,so nothing worth testing.

Details

In response to this:

/verified by @wking, nobody is consuming this yet, so nothing worth testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9778f4f into openshift:main May 1, 2026
3 checks passed
@wking wking deleted the yarn-update-and-hermetic-builds branch May 1, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants