OCPBUGS-115007: Remove BootImageSkewEnforcement feature gate from Default API

[proietfb]

As part of OCPBUGS-105412 this PR has the meaning of removing BootImageSkewEnforcement default api gate.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@proietfb: This pull request references Jira Issue OCPBUGS-115007, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

As part of OCPBUGS-105412 this PR has the meaning of removing BootImageSkewEnforcement default api gate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @proietfb! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 7cb5f130-a18e-414b-9c72-cabbd20f11da

📥 Commits

Reviewing files that changed from the base of the PR and between 6e56fc7 and 2e5d2cc.

⛔ Files ignored due to path filters (7)

• operator/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/zz_generated*
• operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/BootImageSkewEnforcement.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/IrreconcilableMachineConfig.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/ManagedBootImagesAWSCAPI.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/ManagedBootImagesCPMS+ManagedBootImagesAWSCAPI.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• operator/v1/zz_generated.featuregated-crd-manifests/machineconfigurations.operator.openshift.io/ManagedBootImagesCPMS.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**

📒 Files selected for processing (1)

• operator/v1/types_machineconfiguration.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The change removes BootImageSkewEnforcement from the feature gate registry, documentation, enabled 4.10 HyperShift and SelfManagedHA profiles, and related test configuration. It also removes feature-gate markers from the boot image skew fields and makes four validation rules unconditional.

Suggested reviewers: joelspeed

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 2e5d2

The feature gate removal and unconditional validation updates are complete, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the removal of the BootImageSkewEnforcement feature gate from the Default API, which matches the main changeset.
Description check	✅ Passed	The description states that the PR removes the BootImageSkewEnforcement default API gate, which is directly related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes only test metadata by removing feature-gate declarations. No test title changes occur. The affected test titles use static descriptions such as configuration modes and f…
Test Structure And Quality	✅ Passed	PASS: The pull request does not change Ginkgo test code. The only test-related changes remove BootImageSkewEnforcement from two declarative YAML fixture featureGates lists. No It, BeforeEach, …
Microshift Test Compatibility	✅ Passed	The pull request adds no new Ginkgo e2e tests. The only test-related changes remove feature-gate entries from existing MachineConfiguration YAML test configurations. The changed Go files contain featu…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request adds no new Ginkgo e2e tests. The authoritative diff changes feature declarations, manifests, generated CRD files, and two existing YAML API validation test definitions. The tes…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request removes the BootImageSkewEnforcement feature gate and changes MachineConfiguration validation and generated CRD schemas. The authoritative diff adds or modifies no Deploymen…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes feature-gate declarations, API annotations, generated CRD YAML, feature-gate manifests, and YAML test configuration. The changed lines contain no stdout writes, logging …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added. The changed test-related files are declarative CRD YAML fixtures, and the added diff contains no Ginkgo declarations, IPv4-only networking, or external connectivity…
No-Weak-Crypto	✅ Passed	The pull request changes feature-gate registration, API validation markers, manifests, and generated CRDs. The introduced lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, custom cry…
Container-Privileges	✅ Passed	The pull request changes feature-gate definitions, CRD schemas, test fixtures, and FeatureGate lists. The added lines contain none of privileged: true, hostPID, hostNetwork, hostIPC, `SYS_ADMI…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request only removes a feature gate, changes validation markers, and regenerates CRD/feature-gate manifests. The authoritative diff adds no logging calls or sensitive-data output. No password…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[proietfb]

/hold

Hold until openshift/machine-config-operator#6522 has been merged

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

Need to cleanup usages of this feature gate in our APIs here as well. Looks like:

api/operator/v1/types_machineconfiguration.go

Line 299 in fc72020

// +openshift:enable:FeatureGate=BootImageSkewEnforcement

needs to be removed.

[proietfb]

/unhold

[openshift-ci]

@proietfb: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

These no longer need to be the featureset aware validation, they can switch to the normal kubebuilder +kubebuilder:XValidation:rule=,message= style

[proietfb]

Thanks @JoelSpeed I'm going to update this part.