CORS-4417: Add UniverseDomain field to GCPPlatformStatus

[barbacbd]

No description provided.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@barbacbd: This pull request references CORS-4417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @barbacbd! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[barbacbd]

Documented in Enhancement openshift/enhancements#1977

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0eef1f77-9488-45c7-8a67-9b5663a1a788

📥 Commits

Reviewing files that changed from the base of the PR and between a55f248 and 8d5237b.

⛔ Files ignored due to path filters (3)

• config/v1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*
• openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**, !**/zz_generated*
• openapi/openapi.json is excluded by !openapi/**

📒 Files selected for processing (1)

• config/v1/types_infrastructure.go

---

📝 Walkthrough

Walkthrough

Added an optional universeDomain field to GCPPlatformStatus, with installer and observability documentation and validation enforcing a length between 1 and 253 characters.

Suggested reviewers: joelspeed, everettraven

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided, so relevance to the changeset can't be assessed.	Add a brief description of the change and its purpose, such as adding UniverseDomain to GCPPlatformStatus.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: adding UniverseDomain to GCPPlatformStatus.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only adds a GCP status field and generated schema docs; no test files or Ginkgo titles were changed.
Test Structure And Quality	✅ Passed	No Ginkgo test code changed; the PR only touches schema/docs/generated manifests, and the diff contains no *_test.go or Ginkgo constructs.
Microshift Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only changes GCP status schema and generated OpenAPI/docs, so MicroShift test compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes a GCP status field and generated docs/OpenAPI files.
Topology-Aware Scheduling Compatibility	✅ Passed	Only GCPPlatformStatus schema/docs/OpenAPI changed; no deployment, controller, affinity, nodeSelector, or replica scheduling logic was introduced.
Ote Binary Stdout Contract	✅ Passed	PR only adds a GCP status field and generated schema/docs; no main/init/TestMain/suite setup or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only adds a GCP status field and generated OpenAPI/docs, so IPv6/disconnected network compatibility is not affected.
No-Weak-Crypto	✅ Passed	Only change is GCPPlatformStatus.UniverseDomain plus validation; no weak crypto or secret comparisons appear in the diff/file.
Container-Privileges	✅ Passed	Diff only adds GCP universeDomain and generated docs; patch search found no privileged/host* fields or allowPrivilegeEscalation in manifests.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds a GCP status field and generated schema docs; no logging code or sensitive-data emission was introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[patrickdillon]

Perhaps we should reword this slightly. The intent is that components with GCP credentials should read universe domain from them—the creds are the source of truth and reading from them is more ergononic.

We provide this field for components that may not have creds (MCO looks like it will need the field) as well as general informational purposes.

[theobarberbany]

/test api-review

[theobarberbany]

/test evals-api-review

[openshift-api-review-bot]

API review complete — no issues found.

The new UniverseDomain field on GCPPlatformStatus is well-documented:

• Field purpose and source are clearly described.
• Optional behavior is documented: "When omitted, standard public GCP (googleapis.com) is assumed."
• Both MinLength=1 and MaxLength=253 constraints are documented in the comment ("must be between 1 and 253 characters in length"). The combination of +optional/omitempty with MinLength=1 is correct — the field may be absent, but if set must be non-empty.
• No undocumented cross-field relationships or CEL expressions.
• zz_generated.swagger_doc_generated.go is properly updated to match the field comment.

[openshift-api-review-bot]

API Review

Issues were found and posted as inline comments on this PR.

---

Run locally: claude -p "/api-review" from a clone of this PR.
Iterate locally before pushing — it's faster and doesn't use CI budget.

Job artifacts | Report a problem

[tthvo]

/test verify-hypershift-integration

[openshift-ci]

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	52cbf16	link	true	/test verify-hypershift-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

Could we add any validation here to check that this is a valid domain? Is this just the domain and not a URL?

I wonder if this has to be compliant with the RFC DNS1123 subdomain validation?

Example