Skip to content

OCPBUGS-83756: fix(config/v1): define constants for authentication types as typed constants #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ingvagabund wants to merge 1 commit into
base: release-4.21
Choose a base branch
from
+2 −2
Open

OCPBUGS-83756: fix(config/v1): define constants for authentication types as typed constants #2815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/v1/types_authentication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ type UsernameClaimMapping struct {
// +enum
type UsernamePrefixPolicy string

var (
const (
// NoOpinion let's the cluster assign prefixes. If the username claim is email, there is no prefix
// If the username claim is anything else, it is prefixed by the issuerURL
NoOpinion UsernamePrefixPolicy = ""
Expand Down Expand Up @@ -723,7 +723,7 @@ type PrefixedClaimMapping struct {
type TokenValidationRuleType string

const (
TokenValidationRuleTypeRequiredClaim = "RequiredClaim"
TokenValidationRuleTypeRequiredClaim TokenValidationRuleType = "RequiredClaim"
)

type TokenClaimValidationRule struct {
Expand Down