Skip AnalyticsEngineCompatIT when analytics-engine plugin is absent

[ahkcs]

Description

AnalyticsEngineCompatIT is a coexistence smoke test whose only assertion is that the cluster boots. It is meant to run only in the dedicated :integ-test:analyticsEngineCompatIT Gradle task, which bundles the arrow + analytics-engine plugin stack on a non-security cluster.

The distribution integ-test pipeline behaves differently: it scans every *IT class against the built distribution and runs the with-security variant without the analytics-engine plugin. In that lane the test fails before any test body runs:

org.opensearch.sql.plugin.AnalyticsEngineCompatIT.testClusterStarted
  → org.apache.hc.core5.http.ConnectionClosedException: Connection closed by peer
      at OpenSearchRestTestCase.initClient(OpenSearchRestTestCase.java:216)

Root cause: the test extends a bare OpenSearchRestTestCase, which speaks plain HTTP. Against a TLS-secured cluster the security plugin closes the connection during client init. The existing build.gradle exclude only governs this repo's own integTest task — it does not cover the external distribution pipeline that discovers the class generically.

Fix

Make the test self-inert no matter how it is discovered:

• Extend OpenSearchSQLRestTestCase so the REST client honours the https / user / password system properties of a secured cluster (TLS trust + basic auth), instead of failing the connection.
• Skip via an assumption (assumeTrue) when the analytics-engine plugin is not installed — verified through _cat/plugins. A build without the plugin now reports the test as skipped rather than failed.

Resulting behaviour:

Lane	Before	After
analyticsEngineCompatIT task (plugin present)	pass	pass
Distribution build, no security, no analytics-engine	n/a	skipped
Distribution build, with security, no analytics-engine	FAIL (connection closed)	skipped

Check List

• New functionality includes testing — change is itself an integration test; behaviour validated against secured / unsecured / plugin-absent lanes.
• Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 01ada06)

Here are some key observations to aid the review process:

🧪 No relevant tests

🔒 No security concerns identified

✅ No TODO sections

🔀 No multiple PR themes

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

Latest suggestions up to 01ada06
Explore these optional code suggestions:

Category	Suggestion	Impact
General	Add null-safety check for response body The plugin check may fail if the response body is null or the API returns an unexpected format. Add null-safety checks and handle potential exceptions from getResponseBody to prevent test failures in edge cases where the cluster state is unusual. integ-test/src/test/java/org/opensearch/sql/plugin/AnalyticsEngineCompatIT.java [47-51] Response response = client().performRequest(new Request("GET", "/_cat/plugins?h=component")); String installedPlugins = TestUtils.getResponseBody(response, true); assumeTrue( "analytics-engine plugin not installed — skipping coexistence smoke test", - installedPlugins.contains("analytics-engine")); + installedPlugins != null && installedPlugins.contains("analytics-engine")); Suggestion importance[1-10]: 5 __ Why: Adding a null check for installedPlugins is a reasonable defensive programming practice. However, the impact is moderate since TestUtils.getResponseBody likely handles null cases internally, and the test would fail earlier if the response was malformed. The suggestion correctly identifies the code location and provides a valid improvement.	Low

---

Previous suggestions

Suggestions up to commit 1070afd

Category	Suggestion	Impact
General	Add null-safety check for response body The plugin check may fail if the response body is null or the API returns an unexpected format. Add null-safety checks and handle potential exceptions from getResponseBody to prevent test failures in edge cases where the cluster state is unusual. integ-test/src/test/java/org/opensearch/sql/plugin/AnalyticsEngineCompatIT.java [47-51] Response response = client().performRequest(new Request("GET", "/_cat/plugins?h=component")); String installedPlugins = TestUtils.getResponseBody(response, true); assumeTrue( "analytics-engine plugin not installed — skipping coexistence smoke test", - installedPlugins.contains("analytics-engine")); + installedPlugins != null && installedPlugins.contains("analytics-engine")); Suggestion importance[1-10]: 5 __ Why: Adding a null check for installedPlugins is a reasonable defensive programming practice. However, the suggestion assumes TestUtils.getResponseBody() might return null without evidence from the PR context, and the impact is relatively minor since the test would fail clearly if null were returned.	Low

[github-actions]

Persistent review updated to latest commit 01ada06