[Analytic Engine] Skip PUT+DELETE doc-fixture tests on the analytics-engine storage matrix

[RyanL1997]

Description

Bucket # 22 of the AE-storage failure report (8 failures: unsupported_operation_exception — delete operation not supported.) is not a SQL plugin bug. The exception originates in OpenSearch core's storage layer:

• server/src/main/java/org/opensearch/index/engine/DataFormatAwareEngine.java:691 — delete(...) throws UnsupportedEncodingException("delete operation not supported.")
• server/src/main/java/org/opensearch/index/engine/DataFormatAwareEngine.java:774 — prepareDelete(...) throws UnsupportedOperationException("delete operation not supported.")

DataFormatAwareEngine is the engine that backs analytics-engine indices (parquet / composite). It's append-only by design — per-doc delete is not implemented.

The failing tests are 10 PPL / Calcite integration tests that mutate a shared test index as part of their fixture:

PUT /<index>/_doc/<id>?refresh=true   ← seed a tailored doc for this test
... run query, assert ...
DELETE /<index>/_doc/<id>?refresh=true ← clean up to keep the shared index pristine

This pattern works fine against the default Lucene-backed engine. When the suite is launched with -Dtests.analytics.parquet_indices=true (the AE-storage matrix), the cleanup DELETE trips DataFormatAwareEngine.delete() and the test fails — even though the SQL/PPL behavior under test would otherwise pass.

Fix

Skip these specific tests on the AE-storage matrix using the existing helper PPLIntegTestCase.isAnalyticsParquetIndicesEnabled() paired with Assume.assumeFalse(...). This is the precedent already established in StatsCommandIT (4 sites) and CalciteAnalyticsDatetimeWireFormatIT.init().

Impact

Mode	Behavior
Default integTest / integTestRemote (mainline CI)	unchanged — assumeFalse(false) is a no-op, tests run and assert as before
-Dtests.analytics.parquet_indices=true (AE-storage matrix)	10 affected tests are skipped (logged with reason); bucket # 22 in the report disappears

No assertion is changed, no fixture is refactored, no Lucene-path coverage is lost.

Out of scope

• Engine-level support for delete on DataFormatAwareEngine — major design question, not a test-fix concern.
• Refactoring the affected tests to use per-test indices (drop+recreate instead of per-doc DELETE) — would also fix the issue but is significantly more invasive and unnecessary for clearing the report.

Test plan

• CI: default integTest / integTestRemote passes (no behavior change on Lucene path).
• Manual: re-run the AE-storage matrix and confirm bucket # 22 no longer appears.
• ./gradlew :integ-test:spotlessApply ran clean.
• ./gradlew :integ-test:compileTestJava ran clean.

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 7b05885)

Here are some key observations to aid the review process:

🧪 No relevant tests

🔒 No security concerns identified

✅ No TODO sections

🔀 No multiple PR themes

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Simplify multi-line string concatenation The assumption message is split across multiple lines using string concatenation, which can be simplified. Consider using a text block or a single string literal for better readability and maintainability. integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExpandCommandIT.java [299-302] assumeFalse( - "Test mutates docs via PUT+DELETE, which DataFormatAwareEngine" - + " (analytics-engine storage path) does not support.", + "Test mutates docs via PUT+DELETE, which DataFormatAwareEngine (analytics-engine storage path) does not support.", isAnalyticsParquetIndicesEnabled()); Suggestion importance[1-10]: 3 __ Why: The suggestion correctly identifies that the string concatenation can be simplified into a single line. However, this is a minor style improvement with minimal impact on code quality or functionality. The existing code is already readable and the change is purely cosmetic.	Low

[github-actions]

Persistent review updated to latest commit 7b05885