Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Merges the 16 method variant components into 4 parameterised components, and makes
run_benchmarkparamset-aware as per the results_v4 schema.methods/cycombine,methods/cytonorm(--controls,--target),methods/batchadjust(--controls) andmethods/rpca(--target) replace the*_all_controls*/*_no_controls*/*_one_control*/*_to_goal/*_to_midvariants. The scripts are call-for-call identical to the old variants (verified bit-identical outputs).info.variants.run_benchmarkruns each parameterised method once per paramset and tags every score withparamset_name/paramset(nullfor non-parameterised methods), matchingcommon/schemas/results_v4/results.json.--paramsetsyaml file argument; a method withoutinfo.variantsis run once with its default parameter set.--methods_include/--methods_excludecan now also target a single paramset as<method_id>.<paramset_name>.src/workflows/run_benchmark/paramset_helper.nf.Verified via
viash teston all four components, standalone runs of every non-default branch, and full localrun_benchmarkruns on the test resources -- both with the defaultinfo.variantsand with a custom--paramsetsfile.Note:
cycombine.no_controls_to_goalandcycombine.one_control_to_goalmisbehave on the test dataset (ComBat crash / NaNs). This is pre-existing behaviour of the old variant components, unrelated to this PR.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!