Point scprint's triton at its own ptxas - #112
Merged
Merged
Conversation
Open
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
scprint died on every one of its 12 tasks in the last full run with
which is triton's message for "I do not recognise this CUDA version". The image pins torch 2.2.0+cu121 and triton 2.2.0, whose
ptx_get_version()only maps CUDA 10, 11 and 12, whileopenproblems/base_pytorch_nvidia:1now ships CUDA 13.1 at/usr/local/cuda. Triton finds thatptxasfirst and gives up the momentsimpler_flashJITs a kernel.Triton 2.2 bundles its own CUDA 12.3
ptxas, so pointingTRITON_PTXAS_PATHat it is enough.Verified on a de.NBI T4 by re-running the failing task's own work dir with that variable set: it completes and writes a valid embedding for all 39176 cells.
Also drops the stray commented
# docker_run_args: --gpus allunderrunners:, which had odd indentation and did nothing.Bumping scprint/torch/triton to something that understands CUDA 13 is the real answer, but that pulls on
simpler_flashand the lamin setup, and this is enough to get the method scoring again.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!