Replace exported C API error globals - #4065
Open
paulromano wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another PR focused on avoiding
OPENMC_APIfor Windows support. This PR replaces the exportedOPENMC_E_*variables with a C enum and replaces the fixed-size exported error-message buffer with an internal string exposed through a newopenmc_get_err_msgC API function. C++ and Python callers now retrieve error text through the function instead of accessing shared-library data directly. This also has the nice effect of eliminating the fixed 256-character limit that was in place before.Checklist