Build C++ unit tests against a static library - #4062
Open
paulromano wants to merge 2 commits into
Open
Conversation
shimwell
approved these changes
Aug 13, 2026
shimwell
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I had to do the same changes when prototyping an openmc windows wheel so I'm confident these changes are needed of windows support
One optional name change for your consideration.
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another PR here working toward Windows support. Notably, in #2919 there are a bunch of
OPENMC_APImacros that are added on globals that I'm hoping to avoid. One category is global variables that get used in C++ tests; we can avoid those by compiling the OpenMC C++ sources once in an object library and reuse those objects for both the shared library and a static library dedicated to C++ unit tests. This keeps internal globals used by the tests from defining the shared library interface without compiling the source tree twice.Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)