Support additional columns in GoogleConversationalSearchTracer#36
Open
viniciusdsmello wants to merge 5 commits into
Open
Conversation
Spec for extending GoogleConversationalSearchTracer to accept customer-supplied additional columns (static per-client and per-call), so data like a custom trace ID can be attached to imported rows.
…SearchService tracer
…rsationalSearchService tracer example and RBI sig
Companion to the design spec — the task-by-task plan followed by the subagent-driven implementation of the two feature commits.
Drop the spec and implementation-plan working docs — not intended to live in the repo's docs/ tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additional_columns:support toGoogleConversationalSearchTracer, so callers can attach custom data (e.g. a trace ID) to traced rows — as a static default per client (trace_client) and/or per individualanswer_querycall, with per-call values taking precedence on key conflict.query,answer,latency_ms,timestamp,metadata,steps,context,session_id,user_id) are dropped so custom data can never corrupt core trace fields; non-Hashinput is treated as empty rather than raising.examples/google_tracer.rbto match.Closes OPEN-11569.
Design & Plan
docs/superpowers/specs/2026-07-03-google-tracer-additional-columns-design.mddocs/superpowers/plans/2026-07-03-google-tracer-additional-columns.mdTest plan
bundle exec rake test TEST=./test/openlayer/integrations/google_conversational_search_tracer_test.rb— 6/6 passingbundle exec rubocopon all changed files — no offensesbundle exec rake typecheck:sorbet— no errors🤖 Generated with Claude Code
https://claude.ai/code/session_01116VitmTfihHJwqBV95utA