8250839: Improve test template SSLEngineTemplate with SSLContextTemplate#809
Open
jerboaa wants to merge 2 commits into
Open
8250839: Improve test template SSLEngineTemplate with SSLContextTemplate#809jerboaa wants to merge 2 commits into
jerboaa wants to merge 2 commits into
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
5 tasks
8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
0dc5b58 to
fbe874a
Compare
8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
b09f14a to
a18ae0c
Compare
|
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
fbe874a to
ee90e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean (modulo path changes) test-only backport for bringing in JDK-8284047. In particular, this is preparatory work for JDK-8263188 a dependency for JDK-8284047.
Testing
Thoughts?
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/809/head:pull/809$ git checkout pull/809Update a local copy of the PR:
$ git checkout pull/809$ git pull https://git.openjdk.org/jdk8u-dev.git pull/809/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 809View PR using the GUI difftool:
$ git pr show -t 809Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/809.diff
Using Webrev
Link to Webrev Comment