Skip to content

Adds Scandinavia map#4561

Merged
evanpelle merged 5 commits into
openfrontio:mainfrom
crunchybbb2:scand
Jul 10, 2026
Merged

Adds Scandinavia map#4561
evanpelle merged 5 commits into
openfrontio:mainfrom
crunchybbb2:scand

Conversation

@crunchybbb2

@crunchybbb2 crunchybbb2 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Before opening a PR: discuss new features on Discord first, and file bugs or small improvements as issues. You must be assigned to an approved issue — unsolicited PRs will be auto-closed.

Add approved & assigned issue number here:

Resolves #4543

Description:

Adds Map of Scandinavia. This is highly requested and I'm surprised this map doesnt exist already. The layout is based on the Territorial version.
Land area: 2.47M pixels
Nations: 24, with additional nations totaling to 62.

image Screenshot 2026-07-08 162324

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME crunchybbbbb

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f57b0c47-fbe9-4289-a4f6-e10797923734

📥 Commits

Reviewing files that changed from the base of the PR and between d18998a and ec6a22c.

📒 Files selected for processing (1)
  • resources/maps/scandinavia/manifest.json
✅ Files skipped from review due to trivial changes (1)
  • resources/maps/scandinavia/manifest.json

Walkthrough

Adds the Scandinavia map with source and packaged region data, map metadata, English localization, and game registry entries.

Changes

Scandinavia map

Layer / File(s) Summary
Define Scandinavia map data
map-generator/assets/maps/scandinavia/info.json
Adds map metadata plus primary and additional nation entries with coordinates and flags.
Package map manifest
resources/maps/scandinavia/manifest.json
Adds map identity, categories, resolution data, multiplayer frequency, and nation entries.
Register map and localization
src/core/game/Maps.gen.ts, resources/lang/en.json
Adds the Scandinavia map type, registry entry, and English map name translation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MapSource as Scandinavia map source
  participant Manifest as Map manifest
  participant Registry as Game map registry
  participant Localization as English localization
  MapSource->>Manifest: Provide map metadata and nation coordinates
  Manifest->>Registry: Register Scandinavia metadata
  Localization->>Registry: Resolve map.scandinavia name
Loading

Possibly related PRs

Suggested labels: Maps

Suggested reviewers: evanpelle

Poem

Scandinavia rises, coordinate by coordinate,
Nations gather, neatly enumerated.
A manifest shines, translations sing,
The map registry welcomes a new thing.
Northward the game now sails!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The map files and generated entries match the requested Scandinavia map, but the exact land-area target is not verifiable from the summary. Provide evidence that the new map meets the 2.47M pixel land-area target, such as the map sizing or test output.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is short and clearly matches the main change: adding a Scandinavia map.
Description check ✅ Passed The description is related to the new Scandinavia map and its issue reference.
Out of Scope Changes check ✅ Passed The changes stay focused on adding the Scandinavia map, its manifest, and translation entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@map-generator/assets/maps/scandinavia/info.json`:
- Around line 226-228: The map entry named in the scandinavia info data has a
spelling typo, so update the region name from Mecklenberg to Mecklenburg in the
source record that feeds the generated manifest. Make the change in the relevant
map metadata object that includes coordinates and flag, then regenerate the
manifest so the generated output picks up the corrected name.
- Around line 291-293: Correct the misspelled city name in the map data entry so
the location currently labeled "Vitsebysk" is updated to the proper
transliteration "Vitsebsk"; make the same name change in the corresponding
manifest entry as well so both references stay consistent. Locate the affected
record by its coordinates and the existing "name" field, and update any matching
city label in the manifest to the same corrected spelling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6dff0a40-9914-4963-83e9-173ee0143135

📥 Commits

Reviewing files that changed from the base of the PR and between 921892e and 4f11b6b.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/scandinavia/image.png is excluded by !**/*.png
  • resources/maps/scandinavia/map.bin is excluded by !**/*.bin
  • resources/maps/scandinavia/map16x.bin is excluded by !**/*.bin
  • resources/maps/scandinavia/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (5)
  • map-generator/assets/maps/scandinavia/info.json
  • resources/lang/en.json
  • resources/maps/scandinavia/manifest.json
  • resources/maps/scandinavia/thumbnail.webp
  • src/core/game/Maps.gen.ts

Comment thread map-generator/assets/maps/scandinavia/info.json
Comment thread map-generator/assets/maps/scandinavia/info.json
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jul 9, 2026
@evanpelle evanpelle added this to the v33 milestone Jul 9, 2026
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 9, 2026
@RickD004 RickD004 added the Maps A new map, or adjustments to an existing map itself, its json, etc, label Jul 10, 2026
@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management Jul 10, 2026
@evanpelle evanpelle merged commit c25f898 into openfrontio:main Jul 10, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maps A new map, or adjustments to an existing map itself, its json, etc,

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Adds Map of Scandinavia

3 participants