Skip to content

Germany#4557

Closed
SpeakIsntThere wants to merge 3 commits into
openfrontio:mainfrom
SpeakIsntThere:Germany
Closed

Germany#4557
SpeakIsntThere wants to merge 3 commits into
openfrontio:mainfrom
SpeakIsntThere:Germany

Conversation

@SpeakIsntThere

Copy link
Copy Markdown
Contributor

Fixes a small mistake in #4513

Description:

Sets 1 pixel on the Oder river to be water to allow trade to flow through
Sets 1 pixel on the left side of the Oder to be land and not impassable

image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

Lengy_

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c5b81df-7cfc-406d-b789-3648931aa057

📥 Commits

Reviewing files that changed from the base of the PR and between 274b516 and 4588e8d.

⛔ Files ignored due to path filters (3)
  • map-generator/assets/maps/germany/image.png is excluded by !**/*.png
  • resources/maps/germany/map.bin is excluded by !**/*.bin
  • resources/maps/germany/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (2)
  • resources/maps/germany/manifest.json
  • resources/maps/germany/thumbnail.webp

Walkthrough

This change updates resources/maps/germany/manifest.json, incrementing the num_land_tiles count for both the base map and the map4x entry by 1 each.

Changes

Germany Manifest Update

Layer / File(s) Summary
Update land tile counts
resources/maps/germany/manifest.json
Increments num_land_tiles by 1 in both the top-level map entry and the map4x entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: small-fix

Suggested reviewers: evanpelle

Poem

A tiny hop, a single tile,
Germany's map grows just a mile.
Two numbers nudged, no code to break,
Just counts refreshed for goodness' sake.
🐇🗺️

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague and does not describe the actual map fix. Use a specific title like "Fix Oder river tiles in Germany map" to show the main change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description matches the map fix and stays on-topic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the auto-closed-needs-issue PR closed by gate — see comment for next steps label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Hi @SpeakIsntThere, thanks for the contribution.

This PR was automatically closed because it doesn't fit our contribution workflow:

  • You aren't currently assigned to an issue labelled approved, and
  • The change is larger than 50 lines (our cap for unsolicited contributions).

To contribute to OpenFront:

  1. For bugs or small quality-of-life improvements: open an issue. A maintainer will label it approved if it's something we'll work on.
  2. For feature ideas: discuss in the dev Discord first. We don't accept unsolicited feature PRs — even if they're good ideas, every merged feature is a permanent maintenance burden.
  3. Once an issue is labelled approved, comment asking to be assigned. After you're assigned, you can open a PR referencing that issue.

If you believe this was closed in error, please reach out on our Discord or comment below.

See CONTRIBUTING.md for the full contribution process.

Automated PR gate. Source.

@github-actions github-actions Bot closed this Jul 9, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Jul 9, 2026
@SpeakIsntThere

Copy link
Copy Markdown
Contributor Author

Didn't realise the limit was that low, making an issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-closed-needs-issue PR closed by gate — see comment for next steps

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

1 participant