Skip to content

Adds new Hecate Strait map#4550

Closed
killerwombat02 wants to merge 2 commits into
openfrontio:mainfrom
killerwombat02:main
Closed

Adds new Hecate Strait map#4550
killerwombat02 wants to merge 2 commits into
openfrontio:mainfrom
killerwombat02:main

Conversation

@killerwombat02

@killerwombat02 killerwombat02 commented Jul 9, 2026

Copy link
Copy Markdown

Resolves #4529

Description:

I made the Hecate Strait map and thoroughly tested it.
I added the Haida flag to use for the map.
2248 x 1935, 4.3 million total volume ~1.5 million water
28 nations
As realistic as I could make it for the northern BC Canada coast.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

killerwombat02

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR adds a new map, Hecate Strait, to the game. It includes a map-generator info.json with nation data, a resources manifest.json defining tile dimensions and nations, an English localization entry, and registration of the map in the GameMapType enum and maps array.

Changes

Hecate Strait Map Addition

Layer / File(s) Summary
Map generator info data
map-generator/assets/maps/hecatestrait/info.json
Adds map metadata (id, name, translation key, categories, multiplayer frequency) and a nations array with coordinates, names, strengths, and optional flags.
Map resource manifest
resources/maps/hecatestrait/manifest.json
Defines map/map4x/map16x dimensions, multiplayer frequency, name, nations array, and translation key for the resource manifest.
Localization and map registry wiring
resources/lang/en.json, src/core/game/Maps.gen.ts
Adds the "Hecate Strait" localization string and registers the new map with a GameMapType enum member and a MapInfo entry in the maps array.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • openfrontio/OpenFrontIO#4513: Both PRs extend Maps.gen.ts and resources/lang/en.json to register a new map using the same enum/localization pattern.
  • openfrontio/OpenFrontIO#4456: Both PRs add new map definitions by extending Maps.gen.ts and adding corresponding localization/manifest data.
  • openfrontio/OpenFrontIO#4468: Both PRs update the same generated map registry in Maps.gen.ts plus related localization/manifest data for a new map.

Suggested labels: Maps

Suggested reviewers: evanpelle

Poem

A new strait rises on the map's fair face,
Hecate calls it, a northern place.
Nations plotted, flags unfurled,
One more corner of the game world.
🗺️ Hop in, rabbits, let's explore! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: adding a new Hecate Strait map.
Description check ✅ Passed The description is related to the change and mentions the new map, flag, localization, and testing.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Add map - Hecate Strait

1 participant