Adds Irish Sea map

[RickD004]

Description:

Adds map of the Irish Sea: https://en.wikipedia.org/wiki/Irish_Sea

A relatively small-medium size map of 970k tiles, centered around Isle of Man (slightly modified to be more centered), surrounded in all sides by land.

Since all trade will go around the island, this will create crazy strong pirate players, which have become popular thanks to Youtubers and the Tradeship buff in v32.

19 default nations, with 43 extra nations for a total of 62, for the Humans vs Nations gamemode and Solo games.

irish_sea.mp4

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c5267dfc-ad29-43ab-98e6-0be045e47846

📥 Commits

Reviewing files that changed from the base of the PR and between a320680 and 44c6344.

📒 Files selected for processing (2)

• map-generator/assets/maps/irishsea/info.json
• resources/maps/irishsea/manifest.json

✅ Files skipped from review due to trivial changes (1)

• map-generator/assets/maps/irishsea/info.json

🚧 Files skipped from review as they are similar to previous changes (1)

• resources/maps/irishsea/manifest.json

---

Walkthrough

Adds a new "Irish Sea" map: registers GameMapType.IrishSea and a MapInfo entry, adds the map.irishsea translation, adds resources/maps/irishsea/manifest.json and map-generator/assets/maps/irishsea/info.json with nation and coordinate data, and adds six region entries in resources/countries.json.

Changes

Irish Sea map addition

Layer / File(s)	Summary
Core map registry and translation src/core/game/Maps.gen.ts, resources/lang/en.json	Adds IrishSea to GameMapType, adds a matching MapInfo entry, and adds the map.irishsea translation string.
New country/region dataset entries resources/countries.json	Adds entries for Cheshire, Cumbria, Ireland Green Harp, Kingdom of Ireland, Lancashire, and Merseyside with codes, continent, and names.
Map manifest metadata and nation placements resources/maps/irishsea/manifest.json	Adds manifest metadata, sizing/tile counts, special_team_count, translation_key, and nations/additionalNations coordinate lists.
Map generator source info map-generator/assets/maps/irishsea/info.json	Adds generator info.json with the same map metadata and nation location lists.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4437: Same code path — new GameMapType enum member plus maps entry, manifest, and translation key.
• openfrontio/OpenFrontIO#4513: Same registration pipeline plus parallel additions to map/country/translation JSON data.
• openfrontio/OpenFrontIO#4456: Similar end-to-end map addition with matching registry, translation, and map asset updates.

Suggested labels: Maps

Suggested reviewers: evanpelle, FloPinguin

Poem

A map now opens on the Irish sea,
With flags and names in tidy harmony.
From registry to coast, the path is clear,
New shores appear and players steer. 🌊

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding the Irish Sea map.
Description check	✅ Passed	The description matches the changeset by describing the new Irish Sea map and related map details.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@map-generator/assets/maps/irishsea/info.json`:
- Around line 311-314: The map entry for the Llangollen location has a typo in
its name field; update the JSON object in the Irish Sea map data so the `name`
value for this coordinate entry uses the correct spelling "Llangollen" instead
of "Llangollenes". Make the change in the source data entry so the generated
manifest picks it up automatically.

In `@resources/maps/irishsea/manifest.json`:
- Around line 209-212: The map entry name is misspelled as “Llangollenes” and
should be corrected to “Llangollen” in both the Irish Sea manifest and the
corresponding source info.json record. Update the affected “name” field in the
map data so the town label is consistent across both files.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 83889382-078a-483e-98c0-3527aee73abc

📥 Commits

Reviewing files that changed from the base of the PR and between 901b271 and a320680.

⛔ Files ignored due to path filters (10)

• map-generator/assets/maps/irishsea/image.png is excluded by !**/*.png
• resources/flags/GB-CHE.svg is excluded by !**/*.svg
• resources/flags/GB-CMA.svg is excluded by !**/*.svg
• resources/flags/GB-LAN.svg is excluded by !**/*.svg
• resources/flags/GB-Merseyside.svg is excluded by !**/*.svg
• resources/flags/Ireland Green Harp.svg is excluded by !**/*.svg
• resources/flags/Kingdom of Ireland.svg is excluded by !**/*.svg
• resources/maps/irishsea/map.bin is excluded by !**/*.bin
• resources/maps/irishsea/map16x.bin is excluded by !**/*.bin
• resources/maps/irishsea/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (6)

• map-generator/assets/maps/irishsea/info.json
• resources/countries.json
• resources/lang/en.json
• resources/maps/irishsea/manifest.json
• resources/maps/irishsea/thumbnail.webp
• src/core/game/Maps.gen.ts