feat(alliances): custom alliance duration lobby control

[Zixer1]

Description:

Replaces the "Disable alliances" toggle in the host and single-player lobbies with a "Custom alliances" control: a toggle plus a minutes input (0 to 15, step 1).

• 0 minutes disables alliances, same behavior as the old toggle.
• 1 to 15 sets the alliance duration in minutes.

How it works:

• Adds one game-config field, customAllianceDuration (minutes).
• Config.allianceDuration() uses it when set (and falls back to the existing 5 minute default), and Config.disableAlliances() returns true when it is 0.
• The legacy disableAlliances boolean is still read, so older/archived configs keep working.
• Validation reuses the existing parseBoundedIntegerFromInput and toggle-input-card helpers, so it behaves like the other numeric lobby options (spawn immunity, max timer).
• The join-lobby screen shows "Alliances: {x}m", or "Alliances: Disabled" at 0.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

zixer._

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 26838176-8b79-4eef-8a32-f2f0dad2a836

📥 Commits

Reviewing files that changed from the base of the PR and between 3be026a and c6d04dc.

📒 Files selected for processing (3)

• src/client/HostLobbyModal.ts
• src/client/SinglePlayerModal.ts
• src/client/components/ToggleInputCard.ts

🚧 Files skipped from review as they are similar to previous changes (3)

• src/client/components/ToggleInputCard.ts
• src/client/HostLobbyModal.ts
• src/client/SinglePlayerModal.ts

---

Walkthrough

This PR changes lobby alliance settings from a boolean to a minute-based custom duration across client, server, schema, and localization, and adds cached achievement-eligibility loading in the single-player modal.

Changes

Custom Alliance Duration

Layer / File(s)	Summary
Schema, config, and server sync src/core/Schemas.ts, src/core/configuration/Config.ts, src/server/GameServer.ts	GameConfigSchema accepts customAllianceDuration; Config reads it for alliance disable and duration logic; GameServer.updateGameConfig stores it from incoming config payloads.
Toggle input zero hint src/client/components/ToggleInputCard.ts	ToggleInputCard adds an optional zeroLabel hint and renders it when the enabled input value is numeric zero.
Host lobby custom alliances UI src/client/HostLobbyModal.ts	HostLobbyModal replaces the old alliances toggle with custom alliances state, a minutes input card, updated toggle handling, reset behavior, and a customAllianceDuration payload.
Single player custom alliances UI src/client/SinglePlayerModal.ts	SinglePlayerModal updates defaults, state, rendering, change tracking, reset logic, handlers, and game start payloads to use customAlliances, customAllianceMinutes, and customAllianceDuration.
Join lobby alliance display src/client/JoinLobbyModal.ts	JoinLobbyModal shows alliances as disabled when customAllianceDuration is zero and formats positive values in minutes.
Translations and config tests resources/lang/en.json, tests/CustomAllianceDuration.test.ts	en.json replaces the alliances labels with custom alliances copy and adds the minutes placeholder; the new test file covers zero, max, unset, and legacy boolean behavior.

Achievement Eligibility Caching

Layer / File(s)	Summary
Eligibility loading and medal counting src/client/SinglePlayerModal.ts	SinglePlayerModal adds module-level cached eligibility loading, clears failed in-flight state for retries, and guards medal counts until eligibility manifests finish loading.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4487: Both PRs change src/client/SinglePlayerModal.ts to load and use achievement-eligible maps for the medals UI.

Suggested labels: UI/UX

Suggested reviewers: evanpelle

Poem

A timer blooms where toggles slept,
With minute winds and labels kept.
Zero means off, fifteen still sings,
And medals wait for cached brave things.
⏱️🎮

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: replacing the alliances lobby control with a custom duration flow.
Description check	✅ Passed	The description matches the changeset and explains the new custom alliances control, config field, validation, and UI behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/client/HostLobbyModal.ts`:
- Around line 356-370: The custom alliances toggle is initializing with a zero
value, so enabling it immediately disables the feature when `putGameConfig()`
runs. Update the default/initial input value in `HostLobbyModal`’s
`toggle-input-card` usage to a positive duration, and apply the same fix in
`SinglePlayerModal` so the toggle turns on with a valid non-zero duration. Keep
the change aligned with the existing `handleCustomAlliancesToggle` and
`handleCustomAllianceMinutesInput` flow so the enabled state never serializes as
zero.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8e730bf9-e7bd-46c1-bda0-175c3ce6ecc7

📥 Commits

Reviewing files that changed from the base of the PR and between 1db65a1 and 4498598.

📒 Files selected for processing (8)

• resources/lang/en.json
• src/client/HostLobbyModal.ts
• src/client/JoinLobbyModal.ts
• src/client/SinglePlayerModal.ts
• src/core/Schemas.ts
• src/core/configuration/Config.ts
• src/server/GameServer.ts
• tests/CustomAllianceDuration.test.ts

[JB940]

Would it also be possible to textually replace 0 by disabled? or add (disabled) behind it, whatever works. Feels a tad more finished and I don't think everyone might understand 0 means off

[Zixer1]

edited a little the ui per feedback