Skip to content

Add map chopping block#4143

Open
PatrickPlaysBadly wants to merge 8 commits into
openfrontio:mainfrom
PatrickPlaysBadly:Add-map-chopping-block
Open

Add map chopping block#4143
PatrickPlaysBadly wants to merge 8 commits into
openfrontio:mainfrom
PatrickPlaysBadly:Add-map-chopping-block

Conversation

@PatrickPlaysBadly
Copy link
Copy Markdown
Contributor

@PatrickPlaysBadly PatrickPlaysBadly commented Jun 3, 2026

Resolves #4080

Description:

Add Map Chopping Block
https://youtu.be/NpX73lHiKO8

Increased multiplier for 4 player team games and water nukes (plug in center among other shortcuts). This map was made as a faster alternative to Labyrinth. Map has been modified since last submission to be 'less crazy'.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Discord username:

PlaysBadly

Add raw map files chopping block
updated main.go
rendered map files
updated en.json
updated game.ts
updated mapplaylist.ts
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 824706c9-8409-49d5-aaa2-c78776b571ab

📥 Commits

Reviewing files that changed from the base of the PR and between 19a261f and e1e8b31.

📒 Files selected for processing (1)
  • resources/lang/en.json

Walkthrough

Adds a new "Chopping Block" map: data/manifest files define nations and spawn areas, the map is registered in the generator and game enums, playlist weights and flags are set, and an English localization key is added.

Changes

Chopping Block Map Addition

Layer / File(s) Summary
Map Type Registration and Categorization
src/core/game/Game.ts
GameMapType now includes ChoppingBlock, and mapCategories registers it under arcade.
Map Data Definition and Manifest
map-generator/assets/maps/choppingblock/info.json, resources/maps/choppingblock/manifest.json
Adds primary nations coordinate regions, additionalNations list, and teamGameSpawnAreas rectangles (2-team and 4-team).
Generator and Playlist Integration
map-generator/main.go, src/server/MapPlaylist.ts
Registers "choppingblock" in the generator maps list; adds ChoppingBlock to FREQUENCY (weight 5), SPECIAL_TEAM_MAPS (preferred 4-team), and WATER_NUKES_BOOSTED_MAPS.
English Localization
resources/lang/en.json
Adds map.choppingblock => Chopping Block entry.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

bypass-pr-check

Suggested reviewers

  • evanpelle

Poem

🔪 Chopping Block is drawn and set,
Nations ring the central square,
Spawn boxes marked, the players met,
Rotation weight and names laid bare,
May clever borders claim the air.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add map chopping block' directly describes the main change—adding a new map to the game. It is clear, concise, and accurately reflects the primary objective of the PR.
Description check ✅ Passed The description provides relevant context about the Chopping Block map addition, including design rationale, game mode support, and completed requirements. It clearly relates to the changeset.
Linked Issues check ✅ Passed The PR fully addresses all coding requirements from issue #4080: map dimensions (~1600×1600), nation counts (32 primary + 45 secondary), arcade-style design, 2/4-team support, and proper TypeScript/JSON configuration across all modified files.
Out of Scope Changes check ✅ Passed All changes are directly related to adding the Chopping Block map: map definitions (info.json, manifest.json), game registration (main.go), type definitions (Game.ts), localization (en.json), and playlist configuration (MapPlaylist.ts). No unrelated changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/lang/en.json`:
- Line 612: Update the value for the "choppingblock" key to correct the typo:
change the string "Chpping Block" to "Chopping Block" in the en.json locale
mapping so the display name includes the missing 'o'.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 913d0ecd-0004-40c4-ba91-ace5dca9be9c

📥 Commits

Reviewing files that changed from the base of the PR and between 48609fa and 3d685da.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/choppingblock/image.png is excluded by !**/*.png
  • resources/maps/choppingblock/map.bin is excluded by !**/*.bin
  • resources/maps/choppingblock/map16x.bin is excluded by !**/*.bin
  • resources/maps/choppingblock/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (7)
  • map-generator/assets/maps/choppingblock/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/choppingblock/manifest.json
  • resources/maps/choppingblock/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Comment thread resources/lang/en.json Outdated
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jun 3, 2026
@iiamlewis iiamlewis added this to the v32 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development

Development

Successfully merging this pull request may close these issues.

Add Map Copping Block

2 participants