Skip to content

Hhh #3978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MeowMeowMeow123412345 wants to merge 22 commits into from
Closed

Hhh #3978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2f17462
Add files via upload
MeowMeowMeow123412345 Apr 14, 2026
67dccc0
Merge branch 'openfrontio:main' into main
MeowMeowMeow123412345 Apr 15, 2026
66d2d0b
Add redirect URI to magic link email function
MeowMeowMeow123412345 Apr 15, 2026
312b98e
Refactor getApiBase to use API_DOMAIN env variable
MeowMeowMeow123412345 Apr 15, 2026
e31eaf8
Fix missing newline at end of Api.ts
MeowMeowMeow123412345 Apr 15, 2026
c52d809
Integrate Magic SDK for email link authentication
MeowMeowMeow123412345 Apr 15, 2026
62d2da3
Implement magic credential login feature
MeowMeowMeow123412345 Apr 15, 2026
e0e6bb4
Refactor JWT audience and issuer methods
MeowMeowMeow123412345 Apr 15, 2026
561c464
Add new environment variable getters in Env.ts
MeowMeowMeow123412345 Apr 15, 2026
2361b64
Implement authentication routes with JWT and Magic
MeowMeowMeow123412345 Apr 15, 2026
ec6bac8
Register auth routes in Master.ts
MeowMeowMeow123412345 Apr 15, 2026
0d95418
Add cookie-parser middleware to the server
MeowMeowMeow123412345 Apr 15, 2026
a3573f8
Handle root subdomain in build-deploy script
MeowMeowMeow123412345 Apr 15, 2026
ebcc4d6
Handle root subdomain in deploy script
MeowMeowMeow123412345 Apr 15, 2026
b1c9828
Add SUBDOMAIN variable to example.env
MeowMeowMeow123412345 Apr 15, 2026
995ede5
Update fmt.Println message from 'Hello' to 'Goodbye'
MeowMeowMeow123412345 Apr 15, 2026
99f151b
Add new dependencies to package.json
MeowMeowMeow123412345 Apr 15, 2026
91aa4d0
Fix container name and route host assignment
MeowMeowMeow123412345 Apr 15, 2026
009085b
Add MAGIC_PUBLISHABLE_KEY to environment variables
MeowMeowMeow123412345 Apr 15, 2026
29e7d21
Add path mapping for 'src/*' in tsconfig
MeowMeowMeow123412345 Apr 15, 2026
32fef0b
Update server start scripts to include tsconfig
MeowMeowMeow123412345 Apr 15, 2026
607fe90
Update package-lock.json
MeowMeowMeow123412345 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build-deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ ENV="$1"
HOST="$2"
SUBDOMAIN="$3"

if [ "$SUBDOMAIN" = "root" ] || [ "$SUBDOMAIN" = "@" ]; then
SUBDOMAIN=""
fi

# Step 1: Run build.sh
echo "Step 1: Running build.sh..."
./build.sh "$ENV" "$VERSION_TAG"
Expand Down
10 changes: 9 additions & 1 deletion deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,16 @@ HOST=$2
VERSION_TAG=$3
SUBDOMAIN=$4

if [ "$SUBDOMAIN" = "root" ] || [ "$SUBDOMAIN" = "@" ]; then
SUBDOMAIN=""
fi

# Set subdomain - use the provided subdomain
echo "Using subdomain: $SUBDOMAIN"
if [ -z "$SUBDOMAIN" ]; then
echo "Using root domain (no subdomain)"
else
echo "Using subdomain: $SUBDOMAIN"
fi

# Load common environment variables first
if [ -f .env ]; then
Expand Down
1 change: 1 addition & 0 deletions example.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ GHCR_REPO=your-repo-name
GHCR_TOKEN=your_docker_token_here

DOMAIN=your-domain.com
SUBDOMAIN=www # Set to blank for root domain deployment, or use 'root' when calling deploy scripts.
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Move the comment to its own line to avoid .env parse breakage.

On Line 10, inline comments can break your current loader (export $(grep ... | xargs)) by turning comment words into invalid export tokens.

Suggested fix 
-SUBDOMAIN=www  # Set to blank for root domain deployment, or use 'root' when calling deploy scripts.
+# Set to blank for root domain deployment, or use 'root' when calling deploy scripts.
+SUBDOMAIN=www
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
SUBDOMAIN=www # Set to blank for root domain deployment, or use 'root' when calling deploy scripts.
# Set to blank for root domain deployment, or use 'root' when calling deploy scripts.
SUBDOMAIN=www
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@example.env` at line 10, The inline comment after the SUBDOMAIN assignment
can break dotenv parsing (your export $(grep ... | xargs) loader) — move the
comment off the assignment so the line contains only the key/value
(SUBDOMAIN=www) and put the explanatory text on its own line prefixed with #;
update the SUBDOMAIN line in the file (referencing the SUBDOMAIN variable) so it
contains no inline comment.


# API Key
API_KEY=your_api_key_here
Expand Down
Loading