Skip to content

Fox/web fragment#917

Open
Kelketek wants to merge 10 commits into
openedx:masterfrom
open-craft:fox/web-fragment
Open

Fox/web fragment#917
Kelketek wants to merge 10 commits into
openedx:masterfrom
open-craft:fox/web-fragment

Conversation

@Kelketek
Copy link
Copy Markdown
Contributor

@Kelketek Kelketek commented Jun 2, 2026

Description

This Pull Request folds web_fragments into the XBlock repository as a cohabitating package.

Supporting information

openedx/web-fragments#309

This PR is built on top of #914 which must be merged first.

Testing instructions

  1. uv sync
  2. uv run python
  3. From within the shell:
  4. import web_fragments
  5. check that web_fragments.__file__ is now the new local package.

salman2013 and others added 8 commits June 1, 2026 15:52
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Use $NEW_VERSION (uppercase) in build_command — PSR v10 variable name
- Add released || 'false' fallback to prevent empty output edge case
- Pass github_token explicitly to PSR action
- Scope concurrency group to workflow+branch name
- Add publish-action step to attach dist to GitHub Release assets
- Add include-package-data = true explicitly to [tool.setuptools]

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove changedir={envsitepackagesdir} from testenv: uv-venv-lock-runner
  resolves site-packages differently, causing pytest to fail finding xblock/
- Drop redundant mv coverage.xml step; file is written to project root directly
- Add .venv/ to pycodestyle exclude to prevent linting of venv dependencies

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pycodestyle only reads config from setup.cfg or tox.ini — it ignores
[tool.pycodestyle] in pyproject.toml. Moving the config to tox.ini
restores the ignore/exclude settings lost when setup.cfg was deleted.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add docs to CI matrix so docs build is validated on every PR
- Use OPENEDX_SEMANTIC_RELEASE_GITHUB_TOKEN in release workflow so
  PSR can bypass branch protections on master
- Remove tag_format override (use PSR default v{version} which
  matches setuptools-scm expectations)
- Add commit_parser_options with minor_tags for feat/docs commits

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
requirements/doc.txt was deleted as part of the uv migration.
RTD added native uv support in April 2026, so use method: uv
with command: sync and the doc dependency group instead of
the old requirements file approach.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 2, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @Kelketek!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Kelketek Kelketek force-pushed the fox/web-fragment branch from 6bb3020 to 21ec195 Compare June 2, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants