Turn the pencil into a save button while editing - #161
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c60862715c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Editing emptied the bar and moved saving into the menu. The pencil now stays and becomes a save button, as on Android. Discarding stays in the menu and now leaves edit mode. EditWorkflowTests drives the round trip through the view controller. One of its checks is an expected failure: tapping a document sets no cursor, which is odrcore's to fix, and the test will ask to be updated once it is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UNugiHVRHVc1CGHgVGW7Dz
andiwand
force-pushed
the
fix-the-edit-workflow
branch
from
August 16, 2026 08:23
c608627 to
8cab066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing emptied the tool bar and moved saving into the menu, so the only sign you were in edit mode was a button that had gone. The pencil now stays and becomes a save button, the way OpenDocument.droid does it. Saving from the bar writes the file and ends the edit, so the page goes back to what was saved and the button back to a pencil; a save that failed stays in the edit, which is the only place that text still exists. Saving has left the menu; discarding is still there and now leaves edit mode instead of staying in it.
EditWorkflowTestsdrives the round trip through the real view controller — the bar's two roles, typing into the page, saving from the bar, saving to the file, discarding — so the workflow has cover it never had.One of its checks is an expected failure. Tapping a document sets no cursor and the keyboard never unfolds, which is why edit mode feels stuck. That one is odrcore's to fix:
.odr-page-outeris drawn atz-index:-1000, which paints the page behind the column holding it, and taps land on the column instead. Handing that over separately. The test records it as expected and will fail — asking to be updated — as soon as a core without the rule is picked up.Rebased onto
mainnow that #159 and #160 are in, so this is the one commit it always was.🤖 Generated with Claude Code