Take odrcore 6.6.0 - #590
Merged
Merged
Conversation
The engine moves from 6.5.0 to 6.6.0, and nothing here has to move with it. The only change to the bindings is GraphicStyle gaining horizontal_position, which nothing in app/src reads, and the format table is untouched - so SupportedDocumentTypes derives the same two sets and STRICT_CATCH's generated intent-filters still match them, which SupportedFormatsTest confirms. What it brings is rendering, and the changelog entry is grouped by what a user would notice rather than by upstream fix: PDFs place their text by their own font, convert cmyk as Adobe does, clip to the crop box and decode JPEG 2000, and one whose content stream carries comments renders at all; a run that names no font is read at its paragraph's, so slide text that was invisible shows and sheet cells are drawn in their own font; a page-anchored frame sits where the page says and a document is laid out on the master page it names, which is a letter's address and date boxes and its letterhead margins; a frame that names a side is put there, so a centred image is centred and stays inside its frame; an empty paragraph keeps its height, so a blank line survives a copy; and a deep w:basedOn chain is walked onto a stack rather than recursed, so it no longer takes the process down, with xml parts read once instead of buffered twice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScKEsM7MEV8DY7UkTEhLix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine moves from 6.5.0 to 6.6.0, and nothing here has to move with it. The
only change to the bindings is
GraphicStylegaininghorizontal_position,which nothing in
app/srcreads, and the format table is untouched — soSupportedDocumentTypesderives the same two sets andSTRICT_CATCH'sgenerated intent-filters still match them.
What it brings is rendering. The changelog entry is grouped by what a user would
notice rather than by upstream fix:
(small text was landing several points low), convert cmyk as Adobe converts it,
clip to the crop box, and decode JPEG 2000 images. One whose content stream
carries comments renders at all —
%to end of line is white space wherever itstands, not the start of a token.
there but invisible now shows, and sheet cells are drawn in the font the file
names for them.
and a document is laid out on the master page it names, which is a letter's
address and date boxes landing in their fields and its letterhead margins
surviving.
offset is put on that side, so a centred image in an .odt is centred.
survives being copied out.
w:basedOn/style:parent-style-namechain is walked onto a stackrather than recursed, so its length no longer takes the process down, and xml
parts are read once instead of buffered twice on the way into the parser.
Upstream release: https://github.com/opendocument-app/OpenDocument.core/releases/tag/v6.6.0
Testing
spotlessCheck assembleProDebug testProDebugUnitTest— passconnectedProDebugAndroidTeston a Pixel_6_Pro AVD — 69/69 pass, includingSupportedFormatsTest, which is what holds the manifest to the core's table.🤖 Generated with Claude Code