Offer github sponsors where there is no pro to sell - #587
Merged
Conversation
Pro and foss both hide the ad removal row, which leaves their settings section with no way to give anything back - and foss deliberately links nothing google, so the play listing was never an option there. A new settings row opens https://github.com/sponsors/opendocument-app, gated on !Features.withAds so it appears in pro and foss and not in lite, whose one money row should stay the purchase that also drops the ads. FUNDING.yml names the sponsor account too; the store links stay. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0148fw92sgxkTduWzBW2mD74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pro and foss both hide the ad removal row, which leaves their settings section with no way to give anything back - and foss deliberately links nothing google, so the play listing was never an option there.
A new settings row,
ACTION_SPONSOR, opens https://github.com/sponsors/opendocument-app. It is gated on!Features.withAds, so it appears in pro and foss and not in lite: lite's one money row should stay the purchase that also drops the ads, and unlike that row a sponsor row would never go away after a purchase.The link buys nothing inside the app, so it stays a donation rather than an unbilled digital good on the two builds play distributes.
.github/FUNDING.ymlnames the sponsor account as well; the App Store and Play links stay.Built and linted, not seen on a device:
spotlessApply assembleDebug lintProDebugandlintFossDebugpass, andassembleDebugcovers all three flavors.🤖 Generated with Claude Code