Skip to content

test(html): keep page margins in the output tests #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andiwand merged 1 commit into from
Aug 9, 2026
Merged

test(html): keep page margins in the output tests #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/data.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ odr_test_data(
odr_test_data(
PATH "reference-output/odr-public"
URL "https://github.com/opendocument-app/OpenDocument.test.output.git"
REVISION "5d817e661fd9b83aeadf9f9f1b829b658a10303b")
REVISION "e8413d37cfcd943f88bc05b325ee3bb91912212d")

odr_test_data(
PATH "reference-output/odr-private"
URL "https://github.com/opendocument-app/OpenDocument.test-private.output.git"
REVISION "000a6b92c4498797edd0e47a875ff1124ba4eef8")
REVISION "bfe777c6e3236b892dc125d61997036224208fbc")
5 changes: 5 additions & 0 deletions test/src/html_output_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ TEST_P(HtmlOutputTests, html_meta) {
Path(output_path_prefix).parent().join(RelPath("resources")).string();
config.relative_resource_paths = true;
config.editable = true;
// Keep a text document's page margins instead of reflowing it to the
// viewport. The Android viewer turns this on by default, so leaving it off
// here left the reference output showing a rendering path most readers never
// see — including the page box and the backdrop it brings with it.
config.text_document_margin = true;
config.spreadsheet_limit = TableDimensions(4000, 500);
config.page_range_end = 100;
config.format_html = true;
Expand Down
Loading