Support of attr SAI_QUEUE_ATTR_PFC_WD_RESTORATION_MODE - #2338
Open
gurugmarvell wants to merge 1 commit into
Open
Support of attr SAI_QUEUE_ATTR_PFC_WD_RESTORATION_MODE#2338gurugmarvell wants to merge 1 commit into
gurugmarvell wants to merge 1 commit into
Conversation
Signed-off-by: Guruprasad <ggopal@marvell.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation :
SAI currently supports the PFC Watchdog (PFC WD) feature on queues; however, it does not provide a mechanism to configure PFC deadlock recovery modes. This proposal addresses that limitation by introducing a new queue attribute that enables users to configure the desired recovery mode.
Changes:
inc/saiqueue.h
Added a new attribute: SAI_QUEUE_ATTR_PFC_WD_RESTORATION_MODE
Introduced the following restoration mode values:
The default restoration mode is SAI_QUEUE_PFC_WD_RESTORATION_MODE_AUTO.
Added a new attribute: SAI_QUEUE_ATTR_PFC_WD_MANUAL_RESTORATION_TRIGGER
Impact:
This enhancement allows SAI users to configure the PFC WD deadlock recovery behavior using one of three modes: Auto, Force, or Manual. The added flexibility enables users to select the recovery strategy that best aligns with their deployment and operational requirements.
When the PFC WD restoration mode is set to Manual, the user can trigger restoration by setting the new SAI attribute SAI_QUEUE_ATTR_PFC_WD_MANUAL_RESTORATION_TRIGGER to TRUE.