[submodule] Update test/ptf to a Python 3.12+ compatible revision - #2337
Open
nicholasching wants to merge 1 commit into
Open
[submodule] Update test/ptf to a Python 3.12+ compatible revision#2337nicholasching wants to merge 1 commit into
nicholasching wants to merge 1 commit into
Conversation
Signed-off-by: Nicholas Ching <nicholaslching@gmail.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
Hi @kcudnik @tjchadaga, when you have a chance, could you please invoke azure pipelines to run checks. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / motivation
test/ptfis pinned at7494366from December 2022. That revision'sptfrunner doesimport impat module scope and usesimp.load_moduleinload_test_modules. Theimpmodule was removed in Python 3.12, so on any modern distribution PTF fails before running a single test:This affects every
sai_testmodule rather than any particular feature. It was found while bringing up a Debian Trixie based test image, which ships Python 3.13.What this change does
test/ptffrom7494366tod587084, the current head ofp4lang/ptfmain. The change that matters is771a452("Replace use of deprecated package imp with current importlib"), present in the new pin and absent from the old.Scope / risk
771a452is the minimum revision that unblocks Python 3.12+, if a smaller step is preferred.Dependencies
None functionally, but as a submodule bump this should be the last of the SAIVPP Phase 4 SAI changes to merge.