[sai_test] Add opt-in port and BFD notification test cases - #2336
Open
nicholasching wants to merge 4 commits into
Open
[sai_test] Add opt-in port and BFD notification test cases#2336nicholasching wants to merge 4 commits into
nicholasching wants to merge 4 commits into
Conversation
Signed-off-by: Nicholas Ching <nicholaslching@gmail.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
Hi @kcudnik @tjchadaga, when you have a chance, could you please invoke azure pipelines to run checks. Thanks! |
Signed-off-by: Nicholas Ching <nicholaslching@gmail.com>
Signed-off-by: Nicholas Ching <nicholaslching@gmail.com>
Signed-off-by: Nicholas Ching <nicholaslching@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / motivation
Part of the SAIVPP unit-test framework.
sai_testcurrently has no coverage for asynchronous SAI notifications: nothing exercisesSAI_SWITCH_ATTR_PORT_STATE_CHANGE_NOTIFYorSAI_SWITCH_ATTR_BFD_SESSION_STATE_CHANGE_NOTIFY. This adds the first tests for that path, using the saithrift notification RPCs added separately.What this change does
test/sai_test/sai_notification_test.py. New module with five classes:PortStateChangeTest,PortStateRecoveryTest,BfdSessionUpTest,BfdSessionDownTestandBfdMultihopTest.vpp_notification_testPTF parameter; the BFD classes additionally requireSIMULATE_SONIC=1. With neither set the module is inert.NO-CARRIERwhilevppctl show hardware-interfacesstill reports the link up and no interface event is ever raised.vppctloutput rather than only re-reading the SAI attribute that the notification path itself writes. All SAI objects and link state are restored infinally/tearDown.Scope / risk
PORT_COUNT=32with per-test isolation, which reported 90 observed selectors and zero regressions against the existing stable baseline.Dependencies
Requires the saithrift notification bridge PR, #2335. The two touch disjoint files and can merge in either order, but these tests are non-functional until the RPCs exist.