Add VLAN-aware MLD Snooping support - #2326
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@kcudnik , This PR also has enum alias added. The failure seems to be related to this. Can you help fix it ? SAI_VLAN_ATTR_IGMP_SNOOPING_ENABLE,
/** @ignore - for backward compatibility */
SAI_VLAN_ATTR_CUSTOM_IGMP_SNOOPING_ENABLE = SAI_VLAN_ATTR_IGMP_SNOOPING_ENABLE, |
Signed-off-by: Anandhi Dhanabalan <adhanabalan@marvell.com>
|
squash commits and force push |
589f95b to
233270b
Compare
|
@tjchadaga could you please assign a reviewer for this PR |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@kcudnik, the failure appears to be due to the enum alias usage. Should I take any action on this, or will you be handling it? Please advice. |
|
i think problem is taht SAI_VLAN_ATTR_CUSTOM_IGMP_SNOOPING_ENABLE is ignored, which is legitimate enum in previous commits, make @ignore enum you are adding, and assign it by SAI_VLAN_ATTR_CUSTOM_IGMP_SNOOPING_ENABLE you will need to squash commits and force push, check locally before you do that , |
|
@kcudnik, just to confirm my understanding: with the following definition, In my case, |
|
no, @ignore is placed on attribute that have the same enum ID as other exdisting attribute, if you have both wih the same value, none of them can be depreacated |
|
@kcudnik , I’m seeing the same meta error irrespective of how the enum is defined. Capturing the error below: Tried both variants: and In both cases, meta flags duplicate enum values. I also noticed similar @ignore usage is already present (e.g. in sainexthopgroup.h): Could you please confirm:
If aliases are not allowed, I’ll retain only |
No description provided.