feat(yjs): immediately notify peers about external doc updates - #3397
Merged
Merged
Conversation
JammingBen
force-pushed
the
feat/yjs-sse-external-updates
branch
8 times, most recently
from
September 21, 2026 09:34
1e45d7c to
f277380
Compare
JammingBen
marked this pull request as ready for review
September 21, 2026 09:48
AlexAndBear
approved these changes
Sep 23, 2026
Member
|
@JammingBen works great, I wonder if we should request a sse feature from the backend team, so share recievers will be notified too ? 馃 |
JammingBen
force-pushed
the
feat/yjs-sse-external-updates
branch
from
September 23, 2026 05:44
f277380 to
76bbc80
Compare
Member
Author
Good point, I will look if any issue already exists and create one if not 馃憤 Edit: see opencloud-eu/opencloud#3578 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notify peers in a yjs session about external doc updates via SSE. Note that this only works if at least on peer receives SSE events for updated files, which is e.g. not the case for share receivers.
closes #3239