Repository navigation
fix(tests): authenticate basic auth requests with the username - #3318
Merged
Merged
Conversation
dschmidt
marked this pull request as ready for review
September 7, 2026 05:52
dschmidt
changed the title
kulmann
marked this pull request as draft
September 10, 2026 08:32
dschmidt
marked this pull request as ready for review
September 27, 2026 07:01
dschmidt
marked this pull request as draft
September 27, 2026 07:01
Contributor
Author
|
@kulmann why did you mark this as draft? |
Contributor
probably due this one. in description:
but I think we can merge it |
v-scharf
approved these changes
Sep 28, 2026
Contributor
Author
|
@kulmann can you undraft and merge? |
dschmidt
marked this pull request as ready for review
October 8, 2026 07:00
dschmidt
marked this pull request as draft
October 8, 2026 07:00
kulmann
marked this pull request as ready for review
October 8, 2026 07:04
dschmidt
force-pushed
the
fix/e2e-basic-auth-username
branch
from
October 8, 2026 07:11
65b4f51 to
da29189
Compare
The user object carries the account name in username, id is only the key
the steps address it by: the create-user step builds it as { id: 'Alice',
username: 'Alice-<run prefix>' } and creates the account under username.
Basic auth sent id, so every request as a created user got a 401 and the
server logged "user: Alice, got code: 6".
Member
|
Sorry, I didn't follow the conversation here. Yes, I marked it as draft because the description mentioned it. I didn't want to block the PR. Sorry for the confusion 馃檲 |
Contributor
Author
|
Updated description :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the e2e suite with
BASIC_AUTH=truefails for every created user: the API setup steps get a 401 and the server logscould not authenticate with username and password user: Alice, got code: 6.getAuthHeaderbuilds the basic credential fromuser.id, but that is only the key the steps address a user by. The create-user step builds{ id: 'Alice', username: 'Alice-<run prefix>' }and creates the account underusername, which becomesonPremisesSamAccountNameand ends up as the LDAPuid, the attribute basic auth logs in with (AUTH_BASIC_LDAP_LOGIN_ATTRIBUTESdefaults touid).usernameis required on theUsertype and set everywhere users are built, so admin and the other dummy users are unaffected: theiridandusernameare identical.