fix: listing versions for share receivers#2667
Merged
Merged
Conversation
JammingBen
force-pushed
the
fix/shares-with-version-history
branch
2 times, most recently
from
0279fdb to
219d2ec
Compare
JammingBen
force-pushed
the
fix/shares-with-version-history
branch
3 times, most recently
from
04f90d6 to
be82d91
Compare
AlexAndBear
approved these changes
Jun 11, 2026
Fixes an issue where file versions were missing for a share receiver despite the permissions of the share allowing the listing of versions. The fix moves the `canListVersions` method from the `SpaceResource` to the `Resource` interface since it should be called on a resource. On a space, it will always return `false`, since spaces don't have versions. This fixes some inconsistencies we had before (this method should represent the permissions on the actual space, not its resources).
JammingBen
force-pushed
the
fix/shares-with-version-history
branch
from
be82d91 to
069dd34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where file versions were missing for a share receiver despite the permissions of the share allowing the listing of versions.
The fix moves the
canListVersionsmethod from theSpaceResourceto theResourceinterface since it should be called on a resource. On a space, it will always returnfalse, since spaces don't have versions. This fixes some inconsistencies we had before (this method should represent the permissions on the actual space, not its resources).Also, it makes sure the
graphPermissionsare set properly when creating share spaces and when loading files via the app wrapper. This is a prerequisite for determining of the user is allowed to list versions.